This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Implement APIs for some threading metrics (CoreCLR) #24113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kouvel
commented
Apr 19, 2019
- API review: https://github.com/dotnet/corefx/issues/35500
- Attempt at replacement for Implement APIs for some threading metrics (CoreCLR) #22754 due to CI issues
…l pending work item counts
kouvel
added
the
* NO MERGE *
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Apr 19, 2019
stephentoub
approved these changes
Apr 19, 2019
kouvel
changed the title
[WIP] Implement APIs for some threading metrics (CoreCLR)
Implement APIs for some threading metrics (CoreCLR)
Apr 20, 2019
kouvel
removed
the
* NO MERGE *
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Apr 20, 2019
Is the counter work coming in a later PR? |
@sywhang would you be doing the counter work for these APIs? If so I'll let you know after the CoreFX PR is also merged to expose the APIs. |
Yeah, I'll be working on the runtime counters that use these APIs, although I don't think we planned on shipping those counters for Preview 5. |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 22, 2019
…4113) Implement APIs for some threading metrics (CoreCLR) API review: https://github.com/dotnet/corefx/issues/35500 Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Apr 22, 2019
…4113) Implement APIs for some threading metrics (CoreCLR) API review: https://github.com/dotnet/corefx/issues/35500 Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 22, 2019
…4113) Implement APIs for some threading metrics (CoreCLR) API review: https://github.com/dotnet/corefx/issues/35500 Signed-off-by: dotnet-bot <[email protected]>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…4113) Implement APIs for some threading metrics (CoreCLR) API review: https://github.com/dotnet/corefx/issues/35500 Commit migrated from dotnet/coreclr@0410c3e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.