Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Large Pages on Linux & macOS #24098

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Large Pages on Linux & macOS #24098

merged 1 commit into from
Apr 19, 2019

Conversation

mjsabby
Copy link

@mjsabby mjsabby commented Apr 18, 2019

Part of #18371.

This change adds Large Pages support for Linux (embedded GC, standalone was done in a previous change) and macOS (both embedded GC and standalone).

@mjsabby
Copy link
Author

mjsabby commented Apr 18, 2019

cc @Maoni0 @janvorli

janvorli
janvorli approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo the nit). Thank you!

src/pal/src/map/virtual.cpp Outdated Show resolved Hide resolved
@mjsabby
Copy link
Author

mjsabby commented Apr 19, 2019

I think the nt x86 checked build is flaky. Is there a way to only retrigger that?

@janvorli
Copy link
Member

Is there a way to only retrigger that?

Yes, click on the details and then on the left, you'll see links to re-run the specific test, re-run all failed tests, etc.

Maoni0
Maoni0 approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjsabby
Copy link
Author

mjsabby commented Apr 19, 2019

I don’t see such a link when I click details. I guess I’ll have to repush to trigger.

@mjsabby
Copy link
Author

mjsabby commented Apr 19, 2019 •
edited
Loading 

Raw output file:      C:\\dotnetbuild\\work\\16e30220-03a3-4fe3-8e6d-58340d696cf2\\Work\\48818002-c712-4708-a55b-4eb594d5db99\\Exec\\Interop\\COM\\Reports\\Interop.COM\\NativeClients\\DefaultInterfaces\\DefaultInterfaces.output.txt
Raw output:
BEGIN EXECUTION
Copying 'C:\\dotnetbuild\\work\\16e30220-03a3-4fe3-8e6d-58340d696cf2\\Payload\\CoreShim.dll'...
        1 file(s) copied.
 \"C:\\dotnetbuild\\work\\16e30220-03a3-4fe3-8e6d-58340d696cf2\\Payload\\corerun.exe\" DefaultInterfaces.exe 
Searching for exe to launch in C:\\dotnetbuild\\work\\16e30220-03a3-4fe3-8e6d-58340d696cf2\\Work\\48818002-c712-4708-a55b-4eb594d5db99\\Exec\\Interop\\COM\\NativeClients\\DefaultInterfaces...
Launching 'C:\\dotnetbuild\\work\\16e30220-03a3-4fe3-8e6d-58340d696cf2\\Work\\48818002-c712-4708-a55b-4eb594d5db99\\Exec\\Interop\\COM\\NativeClients\\DefaultInterfaces\\COMClientDefaultInterfaces.exe'...
Activate class using default interfaces via IUnknown...
Fail to activate class via a default interface...
FALSE: hr == COR_E_INVALIDOPERATION
Test Failure: 0x80004005

@MichalStrehovsky is this test flaky?

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky is this test flaky?

That test is new as of #23970. I have a suspicion the test binaries don't match product binaries that are tested. I've seen something similar this week...

@mjsabby
Copy link
Author

mjsabby commented Apr 19, 2019

@MichalStrehovsky but that's the whole point of testing ... Ok. I guess I'll rerun all the tests again.

@Maoni0 Maoni0 merged commit 4029007 into dotnet:master Apr 19, 2019
@mjsabby mjsabby deleted the largePagesUnix branch April 19, 2019 21:55
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@Maoni0
Large Pages on Linux & macOS (dotnet/coreclr#24098)
12dd59c 
Commit migrated from dotnet/coreclr@4029007
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

@janvorli janvorli janvorli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjsabby @janvorli @MichalStrehovsky @Maoni0