-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Pass -priority=1 argument directly to build-test.cmd #23007
Pass -priority=1 argument directly to build-test.cmd #23007
Conversation
@dotnet-bot help |
Welcome to the dotnet/coreclr Perf help The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
@dotnet-bot test Windows_NT x64 Checked Build and Test |
/azp run coreclr-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding this and fixing!
Windows_NT x64 Checked Build and Test has passed as well as Windows_NT x64 Checked Innerloop Build and Test with the right priority values being passed to build-test.cmd |
Going to merge to unblock Jenkins Pri1 testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means, I believe, that the priority argument is unused except for in build-test.cmd. I believe that is true.
@BruceForstall Correct |
Fixes https://github.com/dotnet/coreclr/issues/22995
Before #21608 build.cmd was calling build-test.cmd with -priority=n argument. After that change this call has been transformed to build-test.cmd arm64 Checked /p:CLRTestPriorityToBuild=1.
Also see https://github.com/dotnet/coreclr/issues/22995#issuecomment-469366377