This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Re-partition MSBuild test groups #22885
Merged
echesakov
merged 3 commits into
dotnet:master
from
echesakov:RePartitionMSBuildTestSlices
Feb 28, 2019
Merged
Re-partition MSBuild test groups #22885
echesakov
merged 3 commits into
dotnet:master
from
echesakov:RePartitionMSBuildTestSlices
Feb 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AaronRobinsonMSFT Can you please take a look at the MSBuild changes ? |
sdmaclea
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new approach. It seems like it will be less likely to lead to missing tests.
Only did a quick scan of the change...
jkoritzinsky
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSBuild logic looks good to me.
jashook
approved these changes
Feb 27, 2019
AaronRobinsonMSFT
approved these changes
Feb 27, 2019
/azp run coreclr-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Both coreclr-ci and coreclr-outerloop have succeeded. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This changes a tests partitioning scheme of coreclr tests in several different ways: 1. Make the test groups are of equal (to some extent) sizes keeping the number of tests in one group less than 1000; 2. As a resulf of 1) this increases a number of groups needed for Pri0 tests to 3 and decreases a number of groups for Pri1 tests to 10; 3. This also changes a way of tests partitioning scheme is defined - instead of explicitly specifying MSBuild Include-patterns this defines a boundaries between test groups in a form of _StartsWith ItemGroup. Then I use StringComparer.Ordinal to pick tests that belong to a particular group. Commit migrated from dotnet/coreclr@39b643f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a tests paritioning scheme of #17161 in several different ways:
All of this was done to mitigate https://github.com/dotnet/coreclr/issues/20236 which I believe caused by OOM due to enormous number of projects loaded during build-tests (same reasoning as in #17161).
Also fixes https://github.com/dotnet/coreclr/issues/22627 and should prevent from such issues in the future.
I want to mention that I was considering using automatic scheme before converging back to the manual one.
There are several problem with automatic partitioning that in theory can be solved but would take too much effort to do this and probably can be postponed:
@dotnet/jit-contrib