-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
I think this should be ok. @sbomer opinions |
It is possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't spend any time looking through them. Agree a "scream" test is probably the easiest way to see if they are still referenced.
Though it does appear that Signing.props may still be relevant. |
Should we remove tests\helixpublish.proj and tests\helixprep.proj (and also related logic in build-test.cmd and build-test.sh)? |
eng/Signing.props is necessary unless something changed under the rug. This is the file that tells the SignTool in Arcade what to sign. |
The musl failure looks real at the moment. It is somehow using the buildpipeline/linux-musl.groovy script. Maybe someone manually configured the musl CI jobs. |
@hoyosjs Thanks |
The musl job was created by |
fbde9f7
to
b66f75a
Compare
Removed those and
Fixed |
b66f75a
to
7a5d88a
Compare
Three separate unrelated failures:
I triggered a re-run of the transient coreclr-ci failures Retriggering the OSX failure. @dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
All the OSX10.12 x64 Checked Innerloop runs are failing. Ignoring |
* Remove old buildpipeline * Remove obsolete publish-packages * Remove obsolete helix scripts Commit migrated from dotnet/coreclr@af6d241
It is not clear to me why these files are still present.
The easiest way to find out is to try to remove them