Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Remove buildpipelines #22835

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Remove buildpipelines #22835

merged 3 commits into from
Feb 26, 2019

Conversation

sdmaclea
Copy link

It is not clear to me why these files are still present.

The easiest way to find out is to try to remove them

@jashook
Copy link

jashook commented Feb 25, 2019

I think this should be ok. @sbomer opinions

@sdmaclea
Copy link
Author

It is possible eng/Signing.props shouldn't be removed. I didn't see any reference to it. We are using microbuild signing now.

Copy link

@RussKeldorph RussKeldorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spend any time looking through them. Agree a "scream" test is probably the easiest way to see if they are still referenced.

@RussKeldorph
Copy link

Though it does appear that Signing.props may still be relevant.

@echesakov
Copy link

Should we remove tests\helixpublish.proj and tests\helixprep.proj (and also related logic in build-test.cmd and build-test.sh)?

@hoyosjs
Copy link
Member

hoyosjs commented Feb 25, 2019

eng/Signing.props is necessary unless something changed under the rug. This is the file that tells the SignTool in Arcade what to sign.

@sdmaclea
Copy link
Author

The musl failure looks real at the moment. It is somehow using the buildpipeline/linux-musl.groovy script. Maybe someone manually configured the musl CI jobs.

@sdmaclea
Copy link
Author

@hoyosjs Thanks
@echesakovMSFT I'll look at those. There are some perf scripts to send to helix. I would like to fix those as they are referencing buildtools.

@sdmaclea
Copy link
Author

sdmaclea commented Feb 25, 2019

The musl job was created by buildpipeline/pipelinejobs.grovvy by https://ci3.dot.net/job/dotnet_coreclr/job/master/job/generator.
I manually disabled https://ci3.dot.net/job/dotnet_coreclr/job/master/job/linux-musl-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/ and the generator by clicking disable job.
I think all the musl pipelines and generator in https://ci3.dot.net/job/dotnet_coreclr/job/master/* can/should be removed.

@sdmaclea sdmaclea force-pushed the remove_buildpipelines branch from fbde9f7 to b66f75a Compare February 25, 2019 20:12
@sdmaclea
Copy link
Author

sdmaclea commented Feb 25, 2019

Should we remove tests\helixpublish.proj and tests\helixprep.proj (and also related logic in build-test.cmd and build-test.sh)?

Removed those and tests/helixperftasks.targets. I also removed the related logic ziptests and PerfTests.

eng/Signing.props is necessary

Fixed

@sdmaclea sdmaclea force-pushed the remove_buildpipelines branch from b66f75a to 7a5d88a Compare February 25, 2019 20:24
@sdmaclea
Copy link
Author

sdmaclea commented Feb 26, 2019

Three separate unrelated failures:

  • 1 instance of #22045 (Test Pri0 Windows_NT x64 checked)
  • 1 instance of Internal Server Error 500 (Pri0 Linux x64 checked)
  • 1 one test aborted (OSX10.12 x64 Checked)

I triggered a re-run of the transient coreclr-ci failures

Retriggering the OSX failure.

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please

@sdmaclea
Copy link
Author

All the OSX10.12 x64 Checked Innerloop runs are failing. Ignoring

@sdmaclea sdmaclea merged commit af6d241 into dotnet:master Feb 26, 2019
@sdmaclea sdmaclea deleted the remove_buildpipelines branch February 26, 2019 01:57
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Remove old buildpipeline

* Remove obsolete publish-packages

* Remove obsolete helix scripts


Commit migrated from dotnet/coreclr@af6d241
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants