This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Eliminate CMake check when CMake isn't going to be used #21040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceForstall
approved these changes
Nov 16, 2018
stephentoub
approved these changes
Nov 16, 2018
|
Thanks, Dan. |
|
This may break again when CoreCLR moves to Arcade... |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid build failure for not having cmake, when it's not needed because you're building only corelib.
I'm fixing this because source.dot.net indexing runs on a queue that does not have cmake installed. Apparently this wasn't a problem a while back when indexing was succeeding.
I didn't make the change for Unix as it's not relevant to source indexing and doesn't seem to matter much otherwise.
cc @alexperovich