Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Move ARM64 Windows boxen to be Helix-provisioned #20204

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Move ARM64 Windows boxen to be Helix-provisioned #20204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netci.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ def static setMachineAffinity(def job, def os, def architecture, def options = n
label('Windows.10.Amd64.ClientRS4.DevEx.Open')
}
} else {
Utilities.setMachineAffinity(job, os, 'arm64-windows_nt')
Utilities.setMachineAffinity(job, 'windows.10.arm64.open')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work. I think you need:

job.with {
    label('Windows.10.Arm64.Open')
}

Is there a "correct" casing (upper/lower)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The queue API is case insensitive, but I think we're trending towards all lower case. Use whatever you like here, case insensitivity (since Service Bus Messaging queues are) is here to stay until we change our queuing technology.
  • I believe the job.with format though is assuming that the build will occur on the ARM machine, not just a test run as this was being used before. I think the setMachineAffinity is still the right way to go, but I defer to @mmitche .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing shouldn't matter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job.with format is identical to the setMachineAffinity format underneath.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see. there's something a little too tricky here, because with the "os" argument, it looks up in the agent table, but without it, it uses it directly.

}
} else {
assert os != 'Windows_NT'
Expand Down