JIT: update lvaGrabTemp for new minopts/debug ref counting approach #19351
Conversation
If the jit has started normal ref counting and is in minopts or debug, set all new temps to be implicitly referenced by default. Closes #19346.
|
@BruceForstall ptal Will be further extended by #19345, but that is not quite ready for prime time. @dotnet-bot test Windows_NT x64 Checked Build and Test |
|
Trying to trigger PRI1 again... @dotnet-bot test Windows_NT x64 Build and Test |
|
@dotnet-bot retest Ubuntu x64 Checked CoreFX Tests |
|
|
||
| unsigned tempNum = lvaCount; | ||
| lvaTable[tempNum].lvType = TYP_UNDEF; // Initialize lvType, lvIsTemp and lvOnFrame |
There was a problem hiding this comment.
nit: I think a comment that applies to multiple lines should be above the first line (though I realize this was already here).
There was a problem hiding this comment.
I'll fix this as part of #19345.
|
@dotnet/dnceng CoreCLR ARM CI seems like it may be having troubles...? |
Our Windows arm64 machines all appear "offline" to Jenkins. |
|
@BruceForstall I'm not sure which Windows ARM64 machines you're referencing, but we're definitely experiencing DNS issues in the on-premises OSX machines, which are co-located with the ARM64 machines and likely to experience the same problem. I'll update if I get more info, @JpratherMS FYI. |
|
The ARM64-AMD-xxx machines are the ones. @jashook / @RussKeldorph and I manage those. |
|
I haven't actually used these machines before, but I checked out 011 and noticed that while DNS resolution did work the OS on it expired over a month ago. This could be part of the problem, automatic login may be failing due to a blocking dialog about windows expiring? |
|
These were also failing w/o this patch in They have been resolved also. |
If the jit has started normal ref counting and is in minopts or debug,
set all new temps to be implicitly referenced by default.
Closes #19346.