-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
@@ -10,6 +10,7 @@ | |||
<RuntimeFrameworkVersion>$(MicrosoftNETCoreAppPackageVersion)</RuntimeFrameworkVersion> | |||
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> | |||
<EnableDefaultCompileItems>false</EnableDefaultCompileItems> | |||
<Platform>AnyCPU</Platform> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this property still used in SDK projects? I always thought of this as a very VS specific property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's still used. By default in SDK projects it seems to be set to x64/x86 etc, rather than AnyCPU. For the cross arm builds, we build the test exes on windows and copy them to arm, so compiling not AnyCPU breaks that.
build-test.cmd
Outdated
@@ -321,7 +321,7 @@ for /l %%G in (1, 1, %__BuildLoopCount%) do ( | |||
set __msbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%";Append=!__AppendToLog! | |||
|
|||
set TestBuildSlice=%%G | |||
call "%__ProjectDir%\run.cmd" build -Project=%__ProjectDir%\tests\build.proj -MsBuildLog=!__msbuildLog! -MsBuildWrn=!__msbuildWrn! -MsBuildErr=!__msbuildErr! %__RunArgs% %__BuildAgainstPackagesArg% %__PriorityArg% %__PassThroughArg% %__unprocessedBuildArgs% | |||
call %__DotnetHost% msbuild %__ProjectDir%\tests\build.proj !__msbuildLog! !__msbuildWrn! !__msbuildErr! %__msbuildArgs% %TargetsWindowsMsbuildArg% %__BuildAgainstPackagesMsbuildArg% %__unprocessedBuildArgs% | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we no longer passing the Priority argument? And do we need to pass TargetsWindowsMsbuildArg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is why I asked for a review 👍 Let me take a look
@@ -321,7 +321,7 @@ for /l %%G in (1, 1, %__BuildLoopCount%) do ( | |||
set __msbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%";Append=!__AppendToLog! | |||
|
|||
set TestBuildSlice=%%G | |||
call "%__ProjectDir%\run.cmd" build -Project=%__ProjectDir%\tests\build.proj -MsBuildLog=!__msbuildLog! -MsBuildWrn=!__msbuildWrn! -MsBuildErr=!__msbuildErr! %__RunArgs% %__BuildAgainstPackagesArg% %__PriorityArg% %__PassThroughArg% %__unprocessedBuildArgs% | |||
call %__DotnetHost% msbuild %__ProjectDir%\tests\build.proj !__msbuildLog! !__msbuildWrn! !__msbuildErr! %__msbuildArgs% %__BuildAgainstPackagesMsbuildArg% %__PriorityArg% %__PassThroughArg% %__unprocessedBuildArgs% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call in this form misses on default parameters passed by run.cmd to msbuild call. One of them already missed in TestWrapper builds is /clp:Summary which prints summary of run. All default parameters are available in config.json in repo root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls restore default parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This has broken pri-1 builds, e.g.:
I'm going to revert it. |
This reverts commit 763142a.
Revert "Build managed tests with dotnet (#19230)"
Similar to the way we now build the xunit wrappers with the CLI dotnet, this change moves the managed projects to use the CLI as the build invoker as well.
On the build servers we only have the 1.1 sdk installed, which leads to failures in the tests when building them using desktop msbuild. While we could install a newer sdk on the build machines, and most developers already have a suitable > 2.0 sdk, this reduces our external dependencies and ensures the builds won't fail due to external environment issues.