This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update documentation for testing #19063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
added
documentation
|
see #18594 |
chsienki
reviewed
Jul 20, 2018
|
|
||
| **!! Note !! -- Passing /p:__BuildOs=[OSX|Linux] is required.** | ||
|
|
||
| >If you omit it you will get the following error: `error MSB4801: The task factory "CodeTaskFactory" could not be loaded because this version of MSBuild does not support it.` | ||
| --- | ||
| Omitting the above will resulting in the following error: `error MSB4801: The task factory "CodeTaskFactory" could not be loaded because this version of MSBuild does not support it.` |
There was a problem hiding this comment.
This is not true as of #19044 (I removed CodeTaskFactory)
There was a problem hiding this comment.
Although users still need to set BuildOS so it ends up in the correct location
There was a problem hiding this comment.
There is literally not enough +1's to describe how good that is to hear. Thanks!
jashook
pushed a commit
to jashook/coreclr
that referenced
this pull request
Aug 14, 2018
* Update documentation for testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.