CoreFX CI Unix Staging commit #18750
Conversation
|
@dotnet-bot test ci please |
|
@dotnet-bot test ci please |
There was a problem hiding this comment.
You are adding default-triggered jobs for Ubuntu x64 Checked & Release, and OSX10.12 Checked & Release.
I thought we agreed to only have Checked default triggered jobs. If you want to create triggers for Debug and Release also (but not default triggered), that would be fine.
Also, can you at the same time remove the default trigger for the Windows Release jobs?
|
@BruceForstall - Sure thing! I had misunderstood that we'd disable Release configurations entirely. |
|
@dotnet-bot test ci please |
Remove IsJitStressTestScenario assert
|
@dotnet-bot test ci please |
|
@dotnet-bot test ci please |
1 similar comment
|
@dotnet-bot test ci please |
netci.groovy
Outdated
| @@ -2808,10 +2840,10 @@ def static shouldGenerateJob(def scenario, def isPR, def architecture, def confi | |||
| } | |||
| break | |||
| case 'corefx_innerloop': | |||
| if (os != 'Windows_NT'|| architecture != 'x64') { | |||
| if ( (os != 'Windows_NT' && os != 'Ubuntu' && os != 'OSX10.12') || architecture != 'x64') { | |||
There was a problem hiding this comment.
Can you please split this into two conditions:
if (os != 'Windows_NT' && os != 'Ubuntu' && os != 'OSX10.12') {
return false
}
if (architecture != 'x64') {
return false
}
netci.groovy
Outdated
| return false | ||
| } | ||
| if(configuration != 'Release' && configuration != 'Checked') { | ||
| if(configuration != 'Checked') { |
There was a problem hiding this comment.
I don't think there's any reason to restrict this to just Checked. Seems like we should just delete this condition and allow all of Debug/Checked/Released jobs.
| @@ -1565,6 +1565,14 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os, | |||
| Utilities.addGithubPRTriggerForBranch(job, branch, "${os} ${architecture} ${configuration} via ILLink", "(?i).*test\\W+${os}\\W+${architecture}\\W+${configuration}\\W+${scenario}.*") | |||
| break | |||
| } | |||
|
|
|||
| else if (scenario == 'corefx_innerloop') { | |||
| if (configuration == 'Checked') { | |||
There was a problem hiding this comment.
To allow non-debug triggers for Debug/Release, this (and the equivalent other code, below) should be:
if (configuration == 'Checked') {
Utilities.addGithubPRTriggerForBranch(job, branch, "${os} ${architecture} ${configuration} CoreFX Tests")
} else {
Utilities.addGithubPRTriggerForBranch(job, branch, "${os} ${architecture} ${configuration} CoreFX Tests", "(?i).*test\\W+${os}\\W+${architecture}\\W+${configuration}\\W+CoreFX Tests.*")
}
|
@dotnet-bot test ci please |
1 similar comment
|
@dotnet-bot test ci please |
Modifying NETCI definition to stage for Unix version of #18365