This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
JIT: refactor logic for removing box upstream side effects #13169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new method `gtTryRemoveBoxUpstreamEffects` to capture the logic for cleaning up after a dead value type box into a utility. Call this from `gtFoldExprSpecial` and now also from the inliner when it finds a dead box argument. Also remove the useless `fgExpandInline` field and associated `fgIsInlining` method, as the jit never set the field to true. No diffs from the refactoring. The inliner case kicks in in 3 places in the test tree. Closes #13136.
|
@JosephTremoulet PTAL |
JosephTremoulet
approved these changes
Aug 2, 2017
src/jit/gentree.cpp
Outdated
| { | ||
| JITDUMP("gtTryRemoveBoxUpstreamEffects called for [%06u]\n", dspTreeID(op)); | ||
|
|
||
| if (!op->IsBoxedValue()) |
There was a problem hiding this comment.
I'm mildly surprised you're checking IsBoxedValue here rather than asserting it here and expecting callers to check.
There was a problem hiding this comment.
Yeah, seems odd. Will update.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new method
gtTryRemoveBoxUpstreamEffectsto capturethe logic for cleaning up after a dead value type box into a utility.
Call this from
gtFoldExprSpecialand now also from the inliner whenit finds a dead box argument.
Also remove the useless
fgExpandInlinefield and associatedfgIsInliningmethod, as the jit never set the field to true.No diffs from the refactoring. The inliner case kicks in in 3 places
in the test tree.
Closes #13136.