This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Don't call AssemblyResolve event for CoreLib resources #12999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of fix for #12668: - CoreLib resource lookup should not raise the AssemblyResolve event because a misbehaving handler could cause an infinite recursion check and fail-fast to be triggered when the resource is not found, as the issue would repeat when reporting that error - A handler could misbehave by returning an assembly that does not match the requested identity or by throwing
This was referenced Jul 24, 2017
jkotas
reviewed
Jul 24, 2017
src/vm/appdomain.cpp
Outdated
| // return an assembly that does not match, and this can cause recursive resource lookups during error | ||
| // reporting. The CoreLib satellite assembly is loaded from relative locations based on the culture, see | ||
| // AssemblySpec::Bind(). | ||
| if (pSpec->GetCodeBase() != nullptr || !pSpec->IsMscorlibSatellite()) |
There was a problem hiding this comment.
What is the purpose of the GetCodeBase check?
There was a problem hiding this comment.
Oh right, this check is redundant here. It's part of the same check done by AssemblySpec::Bind. The AssemblyResolve event is not raised when a code base is provided anyway, I'll remove the code base check.
|
LGTM. |
jkotas
approved these changes
Jul 24, 2017
kouvel
added a commit
to kouvel/coreclr
that referenced
this pull request
Jul 25, 2017
* Don't call AssemblyResolve event for CoreLib resources Part of fix for #12668: - CoreLib resource lookup should not raise the AssemblyResolve event because a misbehaving handler could cause an infinite recursion check and fail-fast to be triggered when the resource is not found, as the issue would repeat when reporting that error - A handler could misbehave by returning an assembly that does not match the requested identity or by throwing * Address feedback
kouvel
added a commit
that referenced
this pull request
Aug 17, 2017
Don't call AssemblyResolve event for CoreLib resources Part of fix for #12668: - CoreLib resource lookup should not raise the AssemblyResolve event because a misbehaving handler could cause an infinite recursion check and fail-fast to be triggered when the resource is not found, as the issue would repeat when reporting that error - A handler could misbehave by returning an assembly that does not match the requested identity or by throwing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for #12668: