This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix issues with early dumps of multi-reg-returning calls. #12843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tree dump code was calling `GetReturnRegCount` before the return type descriptor was initialized, which lead to an assert. This change introduces a new debug-only method that simply returns `0` if the return type desc has not been initialized.
|
@BruceForstall @dotnet/jit-contrib PTAL |
BruceForstall
approved these changes
Jul 17, 2017
src/jit/gentree.h
Outdated
| @@ -3171,6 +3171,13 @@ struct ReturnTypeDesc | |||
| #endif | |||
| } | |||
|
|
|||
| #ifdef DEBUG | |||
| unsigned TryGetReturnRegCount() const | |||
There was a problem hiding this comment.
It would be useful to have a comment here to explain why we need this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree dump code was calling
GetReturnRegCountbefore the return typedescriptor was initialized, which lead to an assert. This change introduces
a new debug-only method that simply returns
0if the return type deschas not been initialized.