Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Commit

Permalink
Add back AssemblyDescription attribute (#24819)
Browse files Browse the repository at this point in the history
This was present in System.Private.CoreLib previously, but removed in recent versions (I compared 3.0.0-preview5-27610-03 and 3.0.0-preview6-27715-05 on macos). It's unclear to me what used to be adding the attribute  - 099177b touched the SPC logic, but even in that change I see no mention of it. Maybe it used to be autogenerated by the old project files. In any case, I believe it should be added back.
Its value used to be System.Private.CoreLib:
```diff
-  .custom instance void System.Reflection.AssemblyDescriptionAttribute::.ctor(string) = ( 01 00 16 53 79 73 74 65 6D 2E 50 72 69 76 61 74   // ...System.Privat
-                                                                                          65 2E 43 6F 72 65 4C 69 62 00 00 )                // e.CoreLib..
```
  • Loading branch information
sbomer authored and AaronRobinsonMSFT committed May 29, 2019
1 parent 90f2960 commit 90e7b68
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/System.Private.CoreLib/System.Private.CoreLib.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
<AssemblyVersion>4.0.0.0</AssemblyVersion>
<ExcludeAssemblyInfoPartialFile>true</ExcludeAssemblyInfoPartialFile>
<GenerateTargetFrameworkAttribute>false</GenerateTargetFrameworkAttribute>
<Description>$(AssemblyName)</Description>
</PropertyGroup>

<!-- Signing -->
Expand Down

0 comments on commit 90e7b68

Please sign in to comment.