This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use shared tooling to build the .NET Core shared framework #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Artifacts look good, only found the expected core-setup version/commit hash differences. |
MichaelSimons
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/dotnet/core-setup/issues/4787.
Use
Microsoft.DotNet.Build.SharedFramework.Sdk, the new location of shared framework tooling. This mirrors the way the WindowsDesktop sharedfx is created, see dotnet/windowsdesktop#1. Split into 3 commits for review, although it's not a huge PR either way.Adds the
sfxprojsubset because it's now possible due to changes in how the restore works. This also brings it in line with dotnet/windowsdesktop.Note that this is a very basic level of shared tooling, and I wouldn't consider it reasonable for other repos to try to use it yet. dotnet/arcade#2704 still tracks that.
This succeeds in an internal build, with only expected build-to-build diffs.