This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Added a rule to remove #region/#endregion directives. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakesays-old
force-pushed
the
RegionRemoval
branch
4 times, most recently
from
fc4363c
to
ee08886
Compare
jakesays-old
force-pushed
the
RegionRemoval
branch
from
ee08886
to
6cd9c49
Compare
| return targetNode; | ||
| } | ||
|
|
||
| class RegionFinder : CSharpSyntaxWalker |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
|
|
||
| namespace Microsoft.DotNet.CodeFormatting.Rules | ||
| { | ||
| [SyntaxRule(RemoveRegionsRule.Name, RemoveRegionsRule.Description, SyntaxRuleOrder.RemoveRegionsRule)] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I do think this needs to be off by default but other than that it looks good. Had 1 Q about the trivia tracking. More out of curiosity than a correctness issue. |
|
It was the only way I could find to go from the node to a SyntaxTrivia. It seems to work, but if there is a more correct way then I'll gladly change it. How do I configure the rule to be off by default? |
|
@JakeSays see the end of the attribute declaration here Essentially |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule to remove regions.