Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Use correct nuget version normalized format #9525

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

wli3
Copy link

@wli3 wli3 commented Jun 21, 2018

Fix https://github.com/dotnet/cli/issues/9409

according to discussion NuGet/Home#6994 format "N" is the right one

@wli3 wli3 force-pushed the fix-pass-nuget-version-format branch from 7440c9f to 3fc2a1a Compare June 21, 2018 01:19
@wli3 wli3 changed the title WIP Use correct nuget version normalized format Use correct nuget version normalized format Jun 21, 2018
@wli3 wli3 requested review from peterhuene and a team June 21, 2018 01:20
@wli3
Copy link
Author

wli3 commented Jun 21, 2018

cc @nkolev92

This matches nuget behavior
if restore with  `<PackageReference Include="global.tool.console.demo" Version="1.0.*" />` there is no warning
and if restore with `<PackageReference Include="global.tool.console.demo" Version="1.0.0" />` there is warning due to no exact 1.0.0 find
@wli3
Copy link
Author

wli3 commented Jun 21, 2018

🔔

@livarcocc livarcocc added this to the 2.1.4xx milestone Jun 21, 2018
@livarcocc
Copy link

@dotnet-bot Test OSX10.12 x64 Release Build

@wli3 wli3 merged commit 488edfa into dotnet:release/2.1.4xx Jun 21, 2018
@wli3 wli3 deleted the fix-pass-nuget-version-format branch June 21, 2018 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants