This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Updating init-tools.cmd to also restore Microsoft.NETCore.Compilers #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Feb 13, 2019
jkotas
reviewed
Feb 13, 2019
| @@ -26,6 +26,7 @@ set MSBUILD_PROJECT_CONTENT= ^ | |||
| ^^^<ItemGroup^^^> ^ | |||
| ^^^<PackageReference Include=^"MicroBuild.Core^" Version=^"%MICROBUILD_VERSION%^" /^^^> ^ | |||
| ^^^<PackageReference Include=^"Microsoft.Net.Compilers^" Version=^"%ROSLYNCOMPILERS_VERSION%^" /^^^> ^ | |||
| ^^^<PackageReference Include=^"Microsoft.NETCore.Compilers^" Version=^"%ROSLYNCOMPILERS_VERSION%^" /^^^> ^ | |||
There was a problem hiding this comment.
Do we also need to copy this over to somewhere? (look for "Copy Roslyn Compilers Over to ToolRuntime" later in this file)
There was a problem hiding this comment.
No, we can just reference it directly from the packages folder as is done on Unix systems.
There was a problem hiding this comment.
I'll double check I didnt miss something, however.
There was a problem hiding this comment.
Yes. Looks like this is fine. Unix (init-tools.sh) does no such copying and everything looks to work correctly locally.
I imagine it would be possible to not copy for the desktop case (and just reference the files directly) as well (it might make some logic simpler), but that would be a separate PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates init-tools.cmd to also restore Microsoft.NETCore.Compilers which allows CoreCLR to be compiled using
dotnet msbuildon Windows.