This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Need to re-default output properties after writing $(OutputPath). #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using SDK-style projects, Microsoft.Common.targets are getting imported before buildtools' targets. Thus when we overwrite $(OutputPath), we need to also reset the other output properties.
weshaggard
reviewed
Jul 6, 2018
| @@ -24,6 +24,18 @@ | |||
| <NuGetDeploySourceItem>Reference</NuGetDeploySourceItem> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(IsReferenceAssembly)'=='true' AND '$(UsingMicrosoftNETSdk)'=='true'"> | |||
| <!-- When not using Sdk-style projects, Microsoft.Common.CurrentVersion.targets, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
weshaggard
approved these changes
Jul 6, 2018
|
@dotnet-bot test this please |
eerhardt
added a commit
to eerhardt/corefx
that referenced
this pull request
Jul 10, 2018
This workaround was necessary until dotnet/buildtools#2091 was merged. Now it can be removed.
eerhardt
added a commit
to dotnet/corefx
that referenced
this pull request
Jul 10, 2018
This workaround was necessary until dotnet/buildtools#2091 was merged. Now it can be removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SDK-style projects, Microsoft.Common.targets are getting imported before buildtools' targets. Thus when we overwrite $(OutputPath), we need to also reset the other output properties.
Fixes the issue described here dotnet/corefx#29831 (comment)