This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Use INamedTypeReference instead in order to also copy the nested class type forwards from the contract assembly #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s type forwards from the contract assembly
|
addresses: dotnet/corefx#11549 |
| @@ -314,7 +314,7 @@ private static IEnumerable<string> EnumerateDocIdsToForward(IAssembly contractAs | |||
| // Make note that all type forwards (including nested) implement INamespaceAliasForType, so do | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks reasonable to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @weshaggard
When a contract contains nested class type-forwards they are getting filtered out by GenFacades because their type is
NonGenericNestedTypewhich doesn't implementINamespaceTypeReference. With this change, I'm usingINamedTypeReferencewhich they do implement and is actually also implemented byINamespaceTypeReferenceso they will be includded.