Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Commit

Permalink
Fixing comment since we are now includding only the nested types that…
Browse files Browse the repository at this point in the history
… are visible outside the assembly.
  • Loading branch information
joperezr committed Sep 18, 2015
1 parent d3a2aed commit c87ddef
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/GenFacades/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -485,12 +485,7 @@ private void AddTypeForward(Assembly assembly, INamedTypeDefinition seedType)
assembly.ExportedTypes = new List<IAliasForType>();
assembly.ExportedTypes.Add(alias);

// Recursively add forwarders for all nested types regardless of their accessibility. This is
// how the C# compiler emits type forwarders for nested types. We might not need them for
// nested types that are not visible outside the assembly, but it is safer to replicate how
// the C# compiler works. Plus, it helps when diffing the output from ildasm for facades
// that were built from source vs. those that were produced by this tool.
//
// Recursively add forwarders only for the nested types that are accessible outside of the assembly.
// NOTE: Some design-time tools can resolve forwarded nested types with only the top-level forwarder,
// but the runtime currently throws a TypeLoadException without explicit forwarders for the nested
// types.
Expand Down

0 comments on commit c87ddef

Please sign in to comment.