-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buffer writes from sources of synchronous writes #9015
Conversation
src/Mvc/Mvc.Formatters.Xml/src/XmlDataContractSerializerOutputFormatter.cs
Show resolved
Hide resolved
src/Mvc/Mvc.Formatters.Xml/src/XmlDataContractSerializerOutputFormatter.cs
Show resolved
Hide resolved
7fd60e4
to
21885b8
Compare
* Require calling CopyTo to copy content to response stream * Use PagedByteBuffer to buffer content in memory
21885b8
to
fa081f6
Compare
|
||
namespace Microsoft.AspNetCore.WebUtilities | ||
{ | ||
internal sealed class PagedByteBuffer : IDisposable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://github.com/aspnet/AspNetCore/blob/master/src/Mvc/Mvc.ViewFeatures/src/Buffers/PagedCharBuffer.cs#L78-L97 without some of the ceremony
Before and after on the MVC Json scenario in Benchmarks (forgot to markdown):
|
🆙 📅 |
src/Mvc/Mvc.Formatters.Xml/src/XmlDataContractSerializerOutputFormatter.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆙 📅
src/Mvc/Mvc.Formatters.Xml/src/XmlDataContractSerializerOutputFormatter.cs
Show resolved
Hide resolved
src/Mvc/Mvc.NewtonsoftJson/src/NewtonsoftJsonOutputFormatter.cs
Outdated
Show resolved
Hide resolved
@aspnet/build any idea what's up with the Windows build failure? I'm seeing it on all my PRs and I couldn't see a issue tracking it. |
@pranavkm see #9477 which is @natemcmaster's work to address this issue. |
Fixes #6397