Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #59091

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[main] Update dependencies from dotnet/runtime #59091

merged 2 commits into from
Nov 22, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 21, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20241122.1
  • Date Produced: November 22, 2024 10:16:35 AM UTC
  • Commit: 4389f9c54d070ca5e0cf7c4931aff56fe36d667f
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
6902088 
…1120.9

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.ServerSentEvents , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 10.0.0-alpha.1.24569.15 -> To Version 10.0.0-alpha.1.24570.9
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners November 21, 2024 13:10
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 21, 2024
dotnet-policy-service[bot]
dotnet-policy-service bot approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
89a1b24 
…1122.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.ServerSentEvents , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 10.0.0-alpha.1.24569.15 -> To Version 10.0.0-alpha.1.24572.1
@lewing
Copy link
Member

lewing commented Nov 22, 2024

@MichalStrehovsky is this related to your eventsource annotation change?

❌ILLink(0,0): error IL2075: System.Diagnostics.Tracing.EventSource.CreateManifestAndDescriptors(Type, String, EventSource, EventManifestOptions): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicFields', 'DynamicallyAccessedMemberTypes.NonPublicFields' in call to 'System.Type.GetFields(BindingFlags)'. The return value of method 'System.Type.GetNestedType(String)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
❌.packages\microsoft.net.illink.tasks\10.0.0-alpha.1.24565.3\build\Microsoft.NET.ILLink.targets(97,5): error NETSDK1144: Optimizing assemblies for size failed.

@captainsafia
Copy link
Member

@MichalStrehovsky @sbomer It appears that the change introduced in dotnet/runtime#110001 might be causing issues for us here.

Our E2E trimming tests in the repo are failing with new errors:

$ dotnet test Microsoft.AspNetCore.DataProtection.TrimmingTests 
Restore complete (0.5s)
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  project failed with 2 error(s) (16.9s) → /Users/captainsafia/git/aspnetcore/darc-main-edbf60e3-3629-41d5-8de1-c4aa7e66c91d/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.DataProtection.TrimmingTests/TestCertificateXmlEncryptor/bin/Debug/net10.0/osx-x64/project.dll
    ILLink : Trim analysis error IL2075: System.Diagnostics.Tracing.EventSource.CreateManifestAndDescriptors(Type, String, EventSource, EventManifestOptions): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicFields', 'DynamicallyAccessedMemberTypes.NonPublicFields' in call to 'System.Type.GetFields(BindingFlags)'. The return value of method 'System.Type.GetNestedType(String)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
    /Users/captainsafia/.nuget/packages/microsoft.net.illink.tasks/10.0.0-alpha.1.24565.3/build/Microsoft.NET.ILLink.targets(97,5): error NETSDK1144: Optimizing assemblies for size failed.
  project failed with 2 error(s) (6.5s) → /Users/captainsafia/git/aspnetcore/darc-main-edbf60e3-3629-41d5-8de1-c4aa7e66c91d/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.DataProtection.TrimmingTests/TestEncryptedXmlDecryptor/bin/Debug/net10.0/osx-x64/project.dll
    ILLink : Trim analysis error IL2075: System.Diagnostics.Tracing.EventSource.CreateManifestAndDescriptors(Type, String, EventSource, EventManifestOptions): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicFields', 'DynamicallyAccessedMemberTypes.NonPublicFields' in call to 'System.Type.GetFields(BindingFlags)'. The return value of method 'System.Type.GetNestedType(String)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
    /Users/captainsafia/.nuget/packages/microsoft.net.illink.tasks/10.0.0-alpha.1.24565.3/build/Microsoft.NET.ILLink.targets(97,5): error NETSDK1144: Optimizing assemblies for size failed.
  project failed with 2 error(s) (6.9s) → /Users/captainsafia/git/aspnetcore/darc-main-edbf60e3-3629-41d5-8de1-c4aa7e66c91d/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.DataProtection.TrimmingTests/TestUnprotectWorksWithX509Certificate/bin/Debug/net10.0/osx-x64/project.dll
    ILLink : Trim analysis error IL2075: System.Diagnostics.Tracing.EventSource.CreateManifestAndDescriptors(Type, String, EventSource, EventManifestOptions): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicFields', 'DynamicallyAccessedMemberTypes.NonPublicFields' in call to 'System.Type.GetFields(BindingFlags)'. The return value of method 'System.Type.GetNestedType(String)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
    /Users/captainsafia/.nuget/packages/microsoft.net.illink.tasks/10.0.0-alpha.1.24565.3/build/Microsoft.NET.ILLink.targets(97,5): error NETSDK1144: Optimizing assemblies for size failed.

Build failed with 6 error(s) in 52.1s

Based on the conversation in the linked issue, it seems like we shouldn't expect this to happen. Any thoughts?

@eerhardt
Copy link
Member

We may just need a new SDK here that contains the previous fix - dotnet/runtime#109814.

In the description of dotnet/runtime#110001, it says it depends on that PR. And the error/warning here says:

.nuget/packages/microsoft.net.illink.tasks/10.0.0-alpha.1.24565.3

which is an older version of dotnet/runtime than what is being updated to here (24572.1).

We should try rerunning with a new SDK that contains the illink.tasks which contains the previous fix - dotnet/runtime#109814. That may solve this error.

@captainsafia
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet-maestro dotnet-maestro bot merged commit 6e492b2 into main Nov 22, 2024
29 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-edbf60e3-3629-41d5-8de1-c4aa7e66c91d branch November 22, 2024 21:30
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @captainsafia @eerhardt