Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build installers at the end of the repo build and allow building with desktop msbuild #58987

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ViktorHofer
Copy link
Member

Build the Installer projects after everythign else got built by adding a new Traversal project that
builds all P2Ps in it in parallel.

Fixes #58984 Unblocks dotnet/sdk#44828

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@ViktorHofer ViktorHofer requested review from wtgodbe and a team as code owners November 15, 2024 15:47
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2024
@ViktorHofer ViktorHofer added the * NO MERGE * Do not merge this PR as long as this label is present. label Nov 15, 2024
@ViktorHofer
Copy link
Member Author

Adding the NO MERGE label until I fully tested the changes inside the VMR

@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch from 4de0a68 to acd5702 Compare November 15, 2024 16:02
@wtgodbe
Copy link
Member

wtgodbe commented Nov 19, 2024

Local Development job failures are unrelated

@ViktorHofer ViktorHofer marked this pull request as draft November 19, 2024 17:25
@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch from 70c81d9 to 31975d7 Compare November 20, 2024 19:17
Build the Installer projects after everythign else
got built by adding a new Traversal project that
builds all P2Ps in it in parallel.

Fixes #58984
Unblocks dotnet/sdk#44828
@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch from ec997da to 1504eaf Compare November 21, 2024 12:04
@ViktorHofer ViktorHofer marked this pull request as ready for review November 21, 2024 12:05
@ViktorHofer ViktorHofer changed the title Build installers at the end of the repo build Build installers at the end of the repo build and allow building with desktop msbuild Nov 21, 2024
@ViktorHofer
Copy link
Member Author

@ellahathaway this will fix the Sign and Publish issue as well inside the VMR.

@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch 3 times, most recently from 83ff852 to 1eb05c2 Compare November 21, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework * NO MERGE * Do not merge this PR as long as this label is present.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-BuildManaged -BuildInstallers doesn't work as installer build too early
2 participants