Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to specify an appsettings file for user-jwts #58605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChrisAnn
Copy link

Adds the ability to specify an appsettings file for user-jwts

Adds the ability to specify an appsettings file for user-jwts

Description

Currently the user-jwts tool amends appsettings.Development.json when adding a mock JWT scheme for local testing. Many people use appsettings.Development.json for environments other than local development, i.e. a cloud Development environment, and so this amendment causes issues. In my particular case, we have appsettings.Local.json instead and so the tool fails to execute because it cannot find appsettings.Development.json.

As described in #56169 this affects multiple other teams too.

This PR allows for an appsettings file to be specified which will be amended instead of the default appsettings.Development.json. The tool still assumes the file lives next to the project, as it currently does, and checks that the file both exists and ends in .json. Tests have been added to confirm the functionality.

Fixes #56169

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Oct 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 31, 2024
@ChrisAnn
Copy link
Author

@dotnet-policy-service agree company="Stack Overflow"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dotnet-user-jwts support custom appsettings json file
3 participants