Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Update Messagepack dependency #58556

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #58547 to release/9.0

/cc @wtgodbe

Update Messagepack dependency

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@github-actions github-actions bot requested review from wtgodbe and a team as code owners October 21, 2024 21:28
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 21, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Oct 21, 2024
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Oct 21, 2024
@wtgodbe wtgodbe merged commit 8219905 into release/9.0 Oct 21, 2024
25 checks passed
@wtgodbe wtgodbe deleted the backport/pr-58547-to-release/9.0 branch October 21, 2024 23:54
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 9.0.x, 9.0.0 Oct 21, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Oct 28, 2024

/backport to release/8.0

Copy link
Contributor Author

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/11558504784

Copy link
Contributor Author

@wtgodbe backporting to release/8.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update Messagepack dependency
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update Messagepack dependency
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor Author

@wtgodbe an error occurred while backporting to release/8.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant