Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Update dependencies from dotnet/runtime #57858

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[release/9.0] Update dependencies from dotnet/runtime #57858

merged 2 commits into from
Sep 13, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 2540898a-e43f-481f-ebbf-08dcbc3038ad
  • Build: 20240912.10
  • Date Produced: September 13, 2024 11:11:37 AM UTC
  • Commit: 9bff9c5017d8444fdf76959c112dd9fed2da9317
  • Branch: refs/heads/release/9.0

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
e505fb0 
…0912.10

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.ServerSentEvents , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rc.2.24461.16 -> To Version 9.0.0-rc.2.24462.10
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners September 13, 2024 13:17
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 13, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Sep 13, 2024

New IL error:

D:\a_work\1\s\src\Components\Forms\src\FieldIdentifier.cs(204,38): error IL3050: Using member 'System.Linq.Expressions.Expression.Lambda(Expression, params ParameterExpression[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Delegate creation requires dynamic code generation. [D:\a_work\1\s\src\Components\Forms\src\Microsoft.AspNetCore.Components.Forms.csproj]

Looks like it's related to dotnet/runtime#107638 & was already fixed in #57742 - CC @BrennanConroy @captainsafia should we apply the same workaround here? We're not supposed to take ad-hoc SDK updates in this branch, if we can avoid it

@BrennanConroy
Copy link
Member

We're not supposed to take ad-hoc SDK updates in this branch, if we can avoid it

What does this comment mean?

Looks like it's related to dotnet/runtime#107638 & was already fixed in #57742

Sure, sounds easy, it was just adding a few attributes.

@captainsafia
Copy link
Member

@wtgodbe @BrennanConroy I was applying the fixes to this branch right as y'all were posting these comments. 😅

We need to update the Expression.Lambda overload we call in Blazor and add more RDC annotations to SignalR. The latest commit should resolve these issues.

@dotnet-maestro dotnet-maestro bot merged commit 4f2a59c into release/9.0 Sep 13, 2024
27 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-release/9.0-49e76c3d-acb6-4a3c-9eb3-72e4dd270e4d branch September 13, 2024 18:45
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc2 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
9.0-rc2
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @BrennanConroy @captainsafia