-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable AllowSynchronousIO by default in all servers #5120
Conversation
Rebase on #4962 |
d1cadd9
to
cdeb46a
Compare
Ready for review. The failures are known logging issues @pakrym is dealing with. |
Hmm, this should have caused more failures, our test code isn't that clean... I'm going to add the same feature to the test server and see what happens. |
cdeb46a
to
f665b0a
Compare
src/Servers/IIS/src/Microsoft.AspNetCore.Server.IIS/IISServerOptions.cs
Outdated
Show resolved
Hide resolved
What's left of the ambition to expose the pipes instead of sticking with streams? |
@NinoFloris that's still happening. #4757 |
f665b0a
to
d164df7
Compare
All other failures look like known unrelated issues. |
There are a bunch of work items for doing this in the 3.0 milestone. We think we have a plan that is both backwards compatible and exposes pipes with streams |
215073b
to
db7175d
Compare
4321c66
to
01996ad
Compare
Blocked by MVC #6397. @davidfowl how about I turn the setting back off by default but merge the other improvements I've made so far like the test fixes, the new test host feature, etc.? |
01996ad
to
4d30780
Compare
Split. #6404 deals with the improvements so far and this PR only deals with changing the defaults. |
The other thing we can do is turn it off in those code paths to keep everything clean. |
I doubt that would be clean. Hundreds of MVC tests are affected on many different code paths. |
I mean no new broken logic would sneak in if we can turn it on globally and enable sync IO on those code paths. |
3c50fd7
to
2ca16da
Compare
01848f4
to
4880d2d
Compare
4880d2d
to
6db3005
Compare
f62a8e8
to
4a8cb9e
Compare
4a8cb9e
to
9c8ff98
Compare
9c8ff98
to
b3c918e
Compare
Ready for a final review. I've added some fixes and workarounds in MVC, and cleaned up a few more tests elsewhere. (The Helix failures are unrelated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double approved.
#4774 #5874
I had to bump IIS's dependencies to get the response compression fix. This will go away when I can rebase on the refs changes.
Let's see how many upstream tests fail...
Blocked by MVC #6397.