Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted items from SharedFx RuntimeConfig #49682

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Remove unwanted items from SharedFx RuntimeConfig #49682

merged 1 commit into from
Jul 27, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 27, 2023

Resolves part of #49486

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 27, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Jul 27, 2023
@wtgodbe wtgodbe mentioned this pull request Jul 27, 2023
Closed
@mkArtakMSFT mkArtakMSFT removed the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Jul 27, 2023
vitek-karas
vitek-karas approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it works (I can't ever tell will msbuild target ordering) this looks correct.

@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 27, 2023

Assuming it works (I can't ever tell will msbuild target ordering) this looks correct.

I confirmed locally it removes the items from the runtimeconfig.json

@wtgodbe wtgodbe merged commit 0c0944f into dotnet:main Jul 27, 2023
@wtgodbe wtgodbe deleted the wtgodbe/RuntimeConfig branch July 27, 2023 19:00
@ghost ghost added this to the 8.0-rc1 milestone Jul 27, 2023
@wtgodbe wtgodbe mentioned this pull request Jul 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

@elinor-fung elinor-fung Awaiting requested review from elinor-fung

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @vitek-karas @mkArtakMSFT