Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix branch Wilson7 tests #49474

Closed
wants to merge 1 commit into from
Closed

Fix branch Wilson7 tests #49474

wants to merge 1 commit into from

Conversation

keegan-caruso
Copy link
Contributor

Fix branch Wilson7 tests

Fix Key Size of test SymmetricSecurityKeys

Newer versions of Identity Model libraries have more strict checks on minimum key sizes

See: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2072

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-signalr Includes: SignalR clients and servers label Jul 17, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 17, 2023
@ghost
Copy link

ghost commented Jul 17, 2023

Thanks for your PR, @keegan-caruso. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jmprieur
jmprieur approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @keegan-caruso

@jmprieur
Copy link
Contributor

@captainsafia for the failure in the first build (new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.)
Is it something we need to fix on our end or your team?

@captainsafia
Copy link
Member

@captainsafia for the failure in the first build (new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.) Is it something we need to fix on our end or your team?

This will be fixed by dotnet/source-build-externals#170.

@captainsafia captainsafia mentioned this pull request Jul 17, 2023
Merged
@captainsafia
Copy link
Member

Closing in favor of #49491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keegan-caruso @jmprieur @captainsafia @BrennanConroy @jennyf19 @adityamandaleeka