Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK #49297

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Update SDK #49297

merged 3 commits into from
Jul 10, 2023

Conversation

captainsafia
Copy link
Member

No description provided.

@captainsafia captainsafia requested review from a team and wtgodbe as code owners July 10, 2023 14:39
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 10, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@captainsafia
Copy link
Member Author

captainsafia commented Jul 10, 2023 •
edited
Loading

src/Http/Routing/test/UnitTests/RoutingMetricsTests.cs(144,32): error TBD: (NETCORE_ENGINEERING_TELEMETRY=Build) 'Microsoft.Extensions.Telemetry.Testing.Metering.CollectedMeasurement' is for evaluation purposes only and is subject to change or removal in future updates. (https://aka.ms/dotnet-extensions-warnings/TBD)

This error in RoutingMetricTests and others looks like a result of dotnet/extensions#4130. It seems sufficient to suppress this diagnostic given its in test. It's not clear to me how to suppress given it hasn't been designated a diagnostic ID yet...

Update: it looks like it is feasible by passing the TBD diagnostic ID.

cc: @RussKie @joperezr Do we expect a more permanent diagnostic ID to land soon for this? Also, is suppressing the diagnostic in test code is the right approach?

wtgodbe
wtgodbe reviewed Jul 10, 2023
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
wtgodbe
wtgodbe requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to overwrite existing NoWarn

@captainsafia @wtgodbe
Update Directory.Build.props
29f45f2 
Co-authored-by: William Godbe <[email protected]>
@RussKie RussKie mentioned this pull request Jul 10, 2023
Closed
@RussKie
Copy link
Member

RussKie commented Jul 10, 2023

src/Http/Routing/test/UnitTests/RoutingMetricsTests.cs(144,32): error TBD: (NETCORE_ENGINEERING_TELEMETRY=Build) 'Microsoft.Extensions.Telemetry.Testing.Metering.CollectedMeasurement' is for evaluation purposes only and is subject to change or removal in future updates. (aka.ms/dotnet-extensions-warnings/TBD)

This error in RoutingMetricTests and others looks like a result of dotnet/extensions#4130. It seems sufficient to suppress this diagnostic given its in test. It's not clear to me how to suppress given it hasn't been designated a diagnostic ID yet...

Update: it looks like it is feasible by passing the TBD diagnostic ID.

cc: @RussKie Igor Velikorossov FTE @joperezr Jose Perez Rodriguez FTE Do we expect a more permanent diagnostic ID to land soon for this? Also, is suppressing the diagnostic in test code is the right approach?

Yes, it should be safe to suppress. This is still WIP (dotnet/extensions#4161). Eventually, there will be IDs defined.

/cc: @geeknoid

RussKie added a commit to dotnet/extensions that referenced this pull request Jul 10, 2023
@RussKie
Update global.json
19ea375 
As per dotnet/aspnetcore#49297
@RussKie RussKie mentioned this pull request Jul 10, 2023
Merged
@captainsafia captainsafia merged commit a944ed3 into main Jul 10, 2023
@captainsafia captainsafia deleted the safia/update-sdk-07102023 branch July 10, 2023 23:10
@ghost ghost added this to the 8.0-preview7 milestone Jul 10, 2023
RussKie added a commit to dotnet/extensions that referenced this pull request Jul 11, 2023
@RussKie
Update SDK (#4162)
b7bc228 
* Update global.json

As per dotnet/aspnetcore#49297

* Update Directory.Build.targets

Suppress TBD

* Fix build
@RussKie RussKie mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@javiercn javiercn javiercn approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-preview7
Development

Successfully merging this pull request may close these issues.
4 participants
@captainsafia @RussKie @javiercn @wtgodbe