-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blazor] Use JSImport for lazy loading assemblies #46437
Conversation
CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, the new version is easier to read. The only idea I got was: can we have names in resources in plural form? resources.lazyAssembly
, resources.pdb
, resources.assembly
-> resources.lazyAssemblies
, resources.pdbs
, resources.assemblies
Those are from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just added some nits, feel free to ignore if you disagree with the changes.
src/Components/WebAssembly/WebAssembly/src/Services/LazyAssemblyLoader.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly/src/Services/LazyAssemblyLoader.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly/src/Services/LazyAssemblyLoader.cs
Outdated
Show resolved
Hide resolved
…lyLoader.cs Co-authored-by: Mackinnon Buck <[email protected]>
…lyLoader.cs Co-authored-by: Mackinnon Buck <[email protected]>
Motivation
getLazyAssemblies
is implemented using legacy/obsolete JS interop.Contributes to #37787
Description
[JSImport]