Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Use simpler Docker tags #45117

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Nov 15, 2022

nit: Correct timeout of source-build job

  • not honoured as a top-level parameter to source-build.yml

- `cherry-pick` of 5f4bc82, Update docker tag to latest schema
  - This change moves all of the docker images to the -latest tag as part of dotnet#10377.
- `cherry-pick` of f79f2d1, Replace -latest docker tags with new schema
  - We changed the latest tags to not include the -latest suffix, so this change updates those tags to the new schema.
- via dotnet#45115, w/ a slight adjustment from rhel-7 to centos-7 in rhel.Dockerfile

nit: Correct timeout of source-build job
- not honoured as a top-level parameter to source-build.yml
@dougbu dougbu requested a review from a team as a code owner November 15, 2022 20:16
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2022
@ghost ghost added this to the 6.0.x milestone Nov 15, 2022
@ghost
Copy link

ghost commented Nov 15, 2022

Hi @dougbu. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@dougbu
Copy link
Member Author

dougbu commented Nov 15, 2022

@michellemcdaniel note eng/common/templates/jobs/source-build.yml needs to be updated too. I didn't do that in anticipation of an Arcade update because we don't use that file.

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Nov 15, 2022
@mmitche mmitche merged commit 90777da into dotnet:release/6.0 Nov 15, 2022
@dougbu dougbu deleted the dougbu/backport.docker.tags/6.0 branch November 16, 2022 02:46
@dougbu dougbu modified the milestones: 6.0.x, 6.0.12 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants