Changing to use the non-generic WriteAsJsonAsync #43960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
brunolins16
added
area-web-frameworks
brunolins16
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
halter73
approved these changes
Sep 14, 2022
Co-authored-by: Stephen Halter <[email protected]>
Co-authored-by: Eirik Tsarpalis <[email protected]>
|
Approved for .NET 7 RC2 (pending CI passing). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43894
Description
After changes in how the S.T.J, incorporated in RC1, we are no longer able to use JSON source generators with Minimal APIs without adding
[JsonSerializable(typeof(object))]to the configuredJsonSerializerContext.dotnet/docs#30755
dotnet/docs#30758
It is happening because we were calling
HttpResponseJsonExtensions.WriteAsJsonAsync<object?>to keep the polymorphic behavior reported here #41724 (comment).In this change we are using the non-generic
HttpResponseJsonExtensions.WriteAsJsonAsyncmethod and providing theruntime typeto the JSON Serializer.Customer Impact
There is no functional impact compared with what we have behavior the S.T.J changes other than make it works with JSON Source Generators.
Regression?
It is a bug, the polymorphism behavior will be kept but now Minimal will works with JSON Source Generators .
Risk
Verification
Packaging changes reviewed?
cc @eiriktsarpalis @dotnet/area-system-text-json