Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom marshallers for source-generated interop to the V2 shapes. #42619

Merged
merged 3 commits into from
Jul 9, 2022
Merged

Update custom marshallers for source-generated interop to the V2 shapes. #42619

merged 3 commits into from
Jul 9, 2022

Conversation

jkoritzinsky
Copy link
Member

Update custom marshallers for source-generated interop to the V2 shapes.

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

We've updated the shape of the custom marshallers based on significant feedback. This PR moves the custom marshallers in ASP.NET Core to use the new shapes so we can remove support for the old shapes.

Contributes to dotnet/runtime#70859

cc: @AaronRobinsonMSFT @elinor-fung

@jkoritzinsky
Update custom marshallers for source-generated interop to the V2 shapes.
0fe498b 
Update shape to match the final shapes

Fix enum name to match approved name
@ghost ghost added the area-runtime label Jul 7, 2022
@Tratcher Tratcher requested review from HaoK and adityamandaleeka July 7, 2022 20:25
@jkoritzinsky jkoritzinsky force-pushed the update-custom-marshallers branch from 3d0d00b to cd6a0f4 Compare July 7, 2022 22:31
@adityamandaleeka
Copy link
Member

LGTM assuming our tests in this area still pass.

@jkoritzinsky
Copy link
Member Author

Test lanes are green, so I’m going to merge this.

@jkoritzinsky jkoritzinsky merged commit 3e50fe3 into dotnet:main Jul 9, 2022
@jkoritzinsky jkoritzinsky deleted the update-custom-marshallers branch July 9, 2022 02:01
@ghost ghost added this to the 7.0-preview7 milestone Jul 9, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@HaoK HaoK Awaiting requested review from HaoK

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
7.0-preview7
Development

Successfully merging this pull request may close these issues.
5 participants
@jkoritzinsky @adityamandaleeka @AaronRobinsonMSFT @elinor-fung @amcasey