Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update IdentityServer4 -> Duende (#33590)" #34317

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Revert "Update IdentityServer4 -> Duende (#33590)" #34317

merged 1 commit into from
Jul 14, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 13, 2021

This reverts commit c754959.

There's some template tests that are failing due to this, reverting for now to address those before trying again

@HaoK HaoK requested review from Tratcher and a team July 13, 2021 21:50
@HaoK HaoK requested review from dougbu, Pilchie and a team as code owners July 13, 2021 21:50
dougbu
dougbu approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to unblock our builds

@dougbu
Copy link
Member

dougbu commented Jul 13, 2021 •
edited
Loading

@HaoK

  1. Any idea why template tests are failing now and weren't in Update IdentityServer4 -> Duende #33590❔
  2. Are you optimistic about redoing Update IdentityServer4 -> Duende #33590 before preview7 cut-off❔

@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021 •
edited
Loading

Yes, I added some coverage of the blazor templates back to ProjectTemplates yesterday, since we had no coverage of the blazor templates... So I caught myself breaking them... It works!

@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021

See dcae2a6

@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021

I guess I didn't rebase from main after I merged that PR as I had both in flight doh

@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021 •
edited by dougbu
Loading

Are you optimistic about redoing Add mariner queue to helix matrix #33590 before preview7 cut-off❔

What's the ask here @dougbu I wasn't aware of anything about mariner/helix that i needed to do still?

@HaoK HaoK enabled auto-merge (squash) July 13, 2021 22:18
@dougbu
Copy link
Member

dougbu commented Jul 13, 2021

What's the ask here @dougbu I wasn't aware of anything about mariner/helix that i needed to do still?

The ask was a typo. I meant #33590. Correcting in earlier comments…

@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021

When's the cutoff? At this point I think its more prudent to get it in early rc1

@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021

This seems like a unrelated to this PR failure... Maybe we should force merge this @dougbu ?

Microsoft.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: SNI_PN11, error: 52 - Unable to locate a Local Database Runtime installation. Verify that SQL Server Express is properly installed and that the Local Database R

@dougbu
Copy link
Member

dougbu commented Jul 13, 2021

Maybe we should force merge this @dougbu ?

If the problem is consistent, I'd be fine w/ that. Didn't come to mind when I hit the "Rerun failed jobs" button but I leave the choice to you. Lemme know.

@dougbu dougbu mentioned this pull request Jul 13, 2021
Merged
@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021

Can see if it automerges after this run, but if it still is failing due to network access to sql server, we should just force merge this since its just a revert

@HaoK
Copy link
Member Author

HaoK commented Jul 13, 2021

I actually do have the template changes ready, which also might fix the build break now :) #34321

@HaoK HaoK merged commit c9c9a9e into main Jul 14, 2021
@HaoK HaoK deleted the haok/revert branch July 14, 2021 00:39
@ghost ghost added this to the 6.0-preview7 milestone Jul 14, 2021
@davidfowl davidfowl mentioned this pull request Jul 14, 2021
Merged
HaoK added a commit that referenced this pull request Jul 14, 2021
@HaoK
Revert "Revert "Update IdentityServer4 -> Duende (#33590)" (#34317)"
5c3b89a 
This reverts commit c9c9a9e.
HaoK added a commit that referenced this pull request Jul 19, 2021
@HaoK
Revert "Revert "Update IdentityServer4 -> Duende (#33590)" (#34317)"
ace37a6 
This reverts commit c9c9a9e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @dougbu