Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added endpoint API explorer to default webhost (#33800)" #34257

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Jul 11, 2021

This reverts commit 2af293d.

See #34208 (comment) for the explanation.

Fixes #34208

PS: Orchard will still fail if this service is added explicitly so I believe the ultimate fix is inside of orchard itself but reverting this for preview7 also unbreaks swashbuckle so it seems like the right short term decision.

@halter73 This takes the preview7 pressure off for #33934 so we can punt it to rc1 if need be.

@davidfowl davidfowl requested a review from Tratcher as a code owner July 11, 2021 04:03
@ghost ghost added the area-runtime label Jul 11, 2021
@davidfowl davidfowl merged commit 223d6e5 into main Jul 11, 2021
@davidfowl davidfowl deleted the davidfowl/revert-endpoints-api-explorer branch July 11, 2021 06:16
@ghost ghost added this to the 6.0-preview7 milestone Jul 11, 2021
@sebastienros
Copy link
Member

@jtkech

@jtkech
Copy link

jtkech commented Jul 16, 2021

@sebastienros

Yes, we had the same kind of problem when migrating from 2.x to 3.x with the routing services that started to be automatically registered at the host level. At the tenant / shell level, when building an isolated container we needed to remove these inherited services before re-registering them.

Here I think we would just need to do the same with the services added by AddEndpointsApiExplorer().

To check it I would need a link to install a 6.0 preview sdk + runtime including this change and before it gets reverted.

@ghost
Copy link

ghost commented Jul 16, 2021

Hi @jtkech. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@davidfowl
Copy link
Member Author

@jtkech you don't need .NET 6 to reproduce the problem. I filed an issue here OrchardCMS/OrchardCore#9921

@jtkech
Copy link

jtkech commented Jul 16, 2021

@davidfowl Okay cool, thanks!

@ghost
Copy link

ghost commented Jul 16, 2021

Hi @jtkech. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrchardCore doesn't work on net6.0
6 participants