-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Added endpoint API explorer to default webhost (#33800)" #34257
Conversation
This reverts commit 2af293d.
Yes, we had the same kind of problem when migrating from 2.x to 3.x with the routing services that started to be automatically registered at the host level. At the tenant / shell level, when building an isolated container we needed to remove these inherited services before re-registering them. Here I think we would just need to do the same with the services added by To check it I would need a link to install a 6.0 preview sdk + runtime including this change and before it gets reverted. |
Hi @jtkech. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
@jtkech you don't need .NET 6 to reproduce the problem. I filed an issue here OrchardCMS/OrchardCore#9921 |
@davidfowl Okay cool, thanks! |
Hi @jtkech. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
This reverts commit 2af293d.
See #34208 (comment) for the explanation.
Fixes #34208
PS: Orchard will still fail if this service is added explicitly so I believe the ultimate fix is inside of orchard itself but reverting this for preview7 also unbreaks swashbuckle so it seems like the right short term decision.
@halter73 This takes the preview7 pressure off for #33934 so we can punt it to rc1 if need be.