Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update templates baseline for recent changes #34186

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Update templates baseline for recent changes #34186

merged 4 commits into from
Jul 8, 2021

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Jul 7, 2021 •
edited
Loading

Addresses #32406

Seems there's some actual failures here related to my last set of changes. I've addressed what I can see and will keep monitoring the checks.

@DamianEdwards DamianEdwards requested a review from Pilchie as a code owner July 7, 2021 21:24
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 7, 2021
@DamianEdwards DamianEdwards requested review from HaoK and pranavkm July 7, 2021 21:24
@DamianEdwards
Add using alias to fix type name conflict in templates
324a329 
These were missed in the previous set of changes.
@DamianEdwards DamianEdwards requested a review from a team as a code owner July 7, 2021 22:23
@DamianEdwards
Update SPA templates
96803ee 
- Use top-level statements
- Use minimal hosting APIs
- #33947 #33944
@DamianEdwards
Fix nullable issue in Blazor Server template
b724a23
@DamianEdwards DamianEdwards merged commit 4cdd594 into main Jul 8, 2021
@DamianEdwards DamianEdwards deleted the damianedwards/32406 branch July 8, 2021 17:11
@ghost ghost added this to the 6.0-preview7 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK approved these changes

@pranavkm pranavkm pranavkm approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@DamianEdwards @pranavkm @HaoK