Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hotReloadProfile to Razor Pages template #31216

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Add hotReloadProfile to Razor Pages template #31216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6cb106
Add hotReloadProfile to Razor Pages template
pranavkm Mar 25, 2021
e61e9d0
Turn off hotReloadProfile for Blazor WebAssembly projects
pranavkm Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ojectTemplates/content/ComponentsWebAssembly-CSharp/Client/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"commandName": "Project",
"dotnetRunMessages": "true",
"launchBrowser": true,
"hotReloadProfile": "blazorwasm",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @SteveSandersonMS / @danroth27

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to hold off on enabling hot reload for Blazor WebAssembly by default until the experience is a bit more baked. Users can opt into trying it out if they want.

Copy link
Member

@lambdageek lambdageek Mar 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off on merging this. I'm working on the bug. I can repro the problem, should have an update by EOD. Most likely turning it off is the right move, but there's a chance it's a low-risk simple fix.

Copy link
Member

@lambdageek lambdageek Mar 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/runtime#50248 for main. Backport is dotnet/runtime#50254.

"inspectUri": "{wsProtocol}://{url.hostname}:{url.port}/_framework/debug/ws-proxy?browser={browserInspectUri}",
//#if(RequiresHttps)
"applicationUrl": "https://localhost:5001;http://localhost:5000",
Expand Down
1 change: 1 addition & 0 deletions ...emplates/Web.ProjectTemplates/content/RazorPagesWeb-CSharp/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"commandName": "Project",
"dotnetRunMessages": "true",
"launchBrowser": true,
"hotReloadProfile": "aspnetcore",
//#if(RequiresHttps)
"applicationUrl": "https://localhost:5001;http://localhost:5000",
//#else
Expand Down