Add API to Renderer to trigger a UI refresh on hot reload #30884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
src/Components/Components/src/RenderTree/RenderTreeDiffBuilder.cs
Outdated
Show resolved
Hide resolved
src/Components/Components/src/RenderTree/RenderTreeDiffBuilder.cs
Outdated
Show resolved
Hide resolved
src/Components/Components/src/RenderTree/RenderTreeDiffBuilder.cs
Outdated
Show resolved
Hide resolved
| internal static class HotReloadManager | ||
| { | ||
| // Hot reload stuff | ||
| internal static bool IsHotReloadEnabled = Environment.GetEnvironmentVariable("COMPLUS_ForceEnc") == "1"; |
There was a problem hiding this comment.
Interesting. Is this temporary or permanent?
There was a problem hiding this comment.
Let me see if we could convince the runtime to add this as a capability.
pranavkm
force-pushed
the
prkrishn/hot-reload-renderer
branch
2 times, most recently
from
eee7f62
to
74c3e04
Compare
pranavkm
force-pushed
the
prkrishn/hot-reload-renderer
branch
from
74c3e04
to
89b9b4b
Compare
pranavkm
commented
Mar 16, 2021
|
🆙 📅 |
src/Components/Components/src/HotReload/IReceiveHotReloadContext.cs
Outdated
Show resolved
Hide resolved
src/Components/Components/src/Microsoft.AspNetCore.Components.csproj
Outdated
Show resolved
Hide resolved
|
@pranavkm is this still draft? |
|
Looks good to me in general, I'm wondering 2 things:
|
| AddToPendingTasks(componentState.Component.SetParametersAsync(initialParameters)); | ||
| } | ||
|
|
||
| await ProcessAsynchronousWork(); |
There was a problem hiding this comment.
Are you sure we should really be doing this asynchronously? That could take a completely arbitrary amount of time, maybe minutes (waiting for any component in the hierarchy to load data). During this indefinite period, there could be:
- Arbitrary user interactions, which will render weirdly because of the hot reload flag
- Other hot reload deltas being applied, interfering with the shared
_pendingTasksfield
I'm suspicious that this should really only be synchronous. We only need the component tree to re-render itself once immediately to update the state in the existing UI. If components do some async data loading, it's up to them to be able to re-render themselves afterwards.
|
|
||
| await ProcessAsynchronousWork(); | ||
| Debug.Assert(_pendingTasks.Count == 0); | ||
| } |
There was a problem hiding this comment.
This also brings up the point that, in some applications, hot reload refreshes might not be as state-preserving as you'd want. Consider if a root (or deep) component always does some async data loading while showing Loading... instead of its child content, then instantiates its descendant subtree. In that case, each code delta is going to retrigger this flow, and you won't get the instant update in the UI you're actually working on (you'll see "Loading..."), and any transient state in descendants will be discarded.
I'm not disputing that you're doing the right thing by re-rendering the whole tree (I'm disputing the async thing, but that's separate). I'm just realising that while our demo cases hot-reloaded really well, there will be some other cases that don't. It will be up to app developers to make their component hierarchies refresh in a nondestructive way to get the best experience. For example they should try to do data loading in OnInitializedAsync rather than OnParametersSetAsync (except if they manually compare old and new parameters) so that each hot reload doesn't rebuild the descendant tree from scratch. We should think about how to set this expectation in how we document and communicate the feature (cc @danroth27).
|
|
||
| Browser.Equal("This component was rendered 2 time(s).", () => Browser.Exists(By.TagName("h2")).Text); | ||
| Browser.Equal("Initial title", () => Browser.Exists(By.TagName("h3")).Text); | ||
| Browser.Equal("Component with ShouldRender=false was rendered 2 time(s).", () => Browser.Exists(By.TagName("h4")).Text); |
There was a problem hiding this comment.
Very cool to see this test. Nice! I wonder if later we'll be able to cover making an actual code edit, e.g., in the template tests.
eerhardt
reviewed
Mar 16, 2021
| <linker> | ||
| <assembly fullname="Microsoft.AspNetCore.Components" > | ||
| <!-- Trim away hot-reload --> | ||
| <type fullname="Microsoft.AspNetCore.Components.HotReload.HotReloadEnvironment"> |
There was a problem hiding this comment.
Do we need/want a feature value here? Or is the idea that whenever you are trimming this assembly, turn off HotReload?
There was a problem hiding this comment.
The latter. We don't have any scenarios where we would want hot reload to be present in a published application, so it just seems prudent to trim it all the time. Do you foresee any reason to put this behind a switch?
There was a problem hiding this comment.
Do you foresee any reason to put this behind a switch?
No, not at this time. I was just making sure my assumption was correct. Maybe sticking a quick comment in the xml file would help.
Just an FYI - in dotnet/runtime we also run the trimmer on each shared fx assembly during the build in order to trim away any dead code (which can be there because of shared source files), and in System.Private.CoreLib it will trim the IL for specific OS and architecture, since CoreLib targets each separately. If you were to ever run the trimmer in this way, this file would still take affect and it would trim away the HotReload stuff during your build. I don't think you have plans to do this, but I just wanted to call it out for informational purposes.
There was a problem hiding this comment.
We do want these types to be present when users are developing, so we couldn't trim it as part of our build. Our codebase has fewer platform specific implementations (DataProtection is the only one that comes to mind which has lots of windows specific code).
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
| { | ||
| internal class HotReloadEnvironment | ||
| { | ||
| public static readonly HotReloadEnvironment Instance = new(Environment.GetEnvironmentVariable("DOTNET_MODIFIABLE_ASSEMBLIES") == "debug"); |
There was a problem hiding this comment.
Is there any chance that a static constructor prevents the linker from removing the type? I would guess that static constructors may always have side effects and hence always have to be left in and will run.
It's probably not a big deal. I'll leave it up to you whether you think it's worth doing in a less convenient way!
There was a problem hiding this comment.
Actually I have no idea how smart the linker is about figuring out whether the static constructor would run or not.
There was a problem hiding this comment.
Static ctors are hard to trim away and guarantee correctness. I believe the only time a static ctor will be trimmed is if the whole type can be trimmed. Maybe also if it was BeforeFieldInit and all the static fields were removed?
@vitek-karas and @MichalStrehovsky would know the exact rules here.
There was a problem hiding this comment.
I think the rule is basically:
- If it's
BeforeFieldInitthen linker may trim it- In this case the
.cctoris preserved only if there's a field preserved on the type
- In this case the
- Otherwise it will always keep it if it keeps the type
There was a problem hiding this comment.
I was able to do some "fun" substitutions.xml to trim references to this type. Here's what the trimmed results look like now:
Removing the interface and the context is difficult because ComponentBase implements it. If we were determined we could turn the context in to a Func<bool> that would eliminate the context type.
Co-authored-by: Steve Sanderson <[email protected]>
…to prkrishn/hot-reload-renderer
pranavkm
added
the
api-ready-for-review
|
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
SteveSandersonMS
approved these changes
Mar 18, 2021
pranavkm
commented
Mar 22, 2021
| Microsoft.AspNetCore.Components.HotReload.HotReloadContext | ||
| Microsoft.AspNetCore.Components.HotReload.HotReloadContext.HotReloadContext() -> void | ||
| Microsoft.AspNetCore.Components.HotReload.HotReloadContext.IsHotReloading.get -> bool | ||
| Microsoft.AspNetCore.Components.HotReload.IReceiveHotReloadContext |
There was a problem hiding this comment.
Can we replace this with a property on RenderHandle? e.g. RenderHandle.IsHotReloading
pranavkm
added
api-approved
eugene2candy
added a commit
to eugene2candy/Home
that referenced
this pull request
Apr 10, 2021
* Update dependencies from https://github.com/dotnet/efcore build 20210315.3 (dotnet#30960) [main] Update dependencies from dotnet/efcore * Feedback from Pranav * Remove regex use in DataProtection (dotnet#30855) * Fix null ref in SyntaxTokenCache (dotnet#30978) Fixes dotnet#27154 * Pool SocketSenders (dotnet#30771) - SocketAsyncEventArgs have lots of state on them and as a result are quite big (~350) bytes at runtime. We can pool these since sends are usually very fast and we can reduce the per connection overhead as a result. - We also allocate one per IOQueue to reduce contention. - Fixed buffer list management - Disposed pool when the transport is disposed - Added project to slnf so running tests in VS was possible - Clear the buffer and buffer list before returning to the pool - This cleans up dumps as the pooled senders don't see references to buffers while pooled in the queue - Keep track of items in the pool separately from the queue count. * Add Consolidated view classifier to make view types internal (dotnet#30976) * Add Consolidated view classifier to make view types internal * Address feedback from peer review * Address feedback and fix tests * Fix nullability of TypeNameHelper.GetTypeDisplayName parameter (dotnet#30987) * [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#30968) [main] Update dependencies from dotnet/runtime dotnet/efcore - Remove assemblies from the ref and runtime pack - Remove more references * Update src/Features/JsonPatch/src/Internal/ConversionResultProvider.cs Co-authored-by: Pranav K <[email protected]> * Update src/Features/JsonPatch/src/PublicAPI.Unshipped.txt Co-authored-by: Pranav K <[email protected]> * Update dependencies from https://github.com/dotnet/efcore build 20210316.2 (dotnet#30991) [main] Update dependencies from dotnet/efcore * HTTP/3 input validation and connection abort (dotnet#29665) * Connection error for invalid HTTP/3 frame on request stream * Update src/Servers/Kestrel/Core/src/CoreStrings.resx * Write frame types and errors codes in logs as per spec * Clean up * Add HTTP/3 connection exception with code * Connection abort * More abort connection stuff * More test * More tests * PR feedback * Update dependencies from https://github.com/dotnet/efcore build 20210317.1 (dotnet#30998) [main] Update dependencies from dotnet/efcore * helix + pw + linux/osx (dotnet#30676) * [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#30999) [main] Update dependencies from dotnet/runtime dotnet/efcore * Dispose streams that don't fit in pool (dotnet#30995) * Dispose streams that don't fit in pool * PR feedback * Update NodeJS dependency in build instructions (dotnet#31000) * Respect consolidated views in all document classifiers (dotnet#31008) * Respect consolidated views in all document classifiers * Address feedback from peer review * E2E test apps for WinForms and WPF BlazorWebView (dotnet#31021) * Add API to Renderer to trigger a UI refresh on hot reload (dotnet#30884) * Add API to Renderer to trigger a UI refresh on hot reload Fixes dotnet#30816 * Update RazorExtensions.cs (dotnet#31029) * Fix credscan issues in aspnetcore (dotnet#30337) * Fix credscan issues in DataProtection * Fix credscan issues in Identity, except where they affect checked in certs * Updated scan * [Blazor] Adds static web assets support for Blazor desktop (dotnet#31041) * Wires up static web assets support on the WebViewManager. * Support ElementReference.Focus in WebView (dotnet#31050) * Support InputFile in WebView (dotnet#31049) * Update DotNetMuxerTest (dotnet#31053) Fixes dotnet#24082 * Bring back working DevServer packaging setup (dotnet#31043) * Bring pack working DevServer packaging setup * Revert "Bring pack working DevServer packaging setup" This reverts commit 0dda92e. * Update runtimeconfig.template.json * Quarantine one failing test (dotnet#31045) - dotnet#31044 - `RazorPagesTemplate_RazorRuntimeCompilation_BuildsAndPublishes()` * Update SDK to bring unified assembly changes (dotnet#31039) * Update SDK to bring unified assembly changes * Update SDK to pick up Razor pages fix * Fixup test Co-authored-by: Pranav K <[email protected]> * Update launchSettings to indicate hotReload is to be used (dotnet#31060) * Fix race in FrameAfterTrailers_UnexpectedFrameError dotnet#30754 (dotnet#31061) * Fix JS interop cases in WebView (dotnet#31054) * Template tests: Create dev cert only once (dotnet#31012) * Simplify Razor bug reports. (dotnet#31033) * Simplify Razor bug reports. - We now have better mechanisms for capturing information so no need to scare users off. * Address code review feedback * [Blazor][Desktop] Mark packages as shipping (dotnet#31035) * Make packages shipping * Update RepoTasks to msbuild 16.9 * Update global.json * Update Nuget * Remove WebView dependency to AspNetCore.App (dotnet#31071) The Blazor Desktop project must not depend on Microsoft.AspNetCore.App because it needs to run on almost any platform, including Android/iOS. But AspNetCore.App doesn't run on those platforms. This changes WebView to not use any packages that are part of AspNetCore.App, such as StaticFiles and Http.Abstractions. Instead, it has copies of those files. * Use longer delay in test (dotnet#31072) * [SignalR TS] Fix permanent Disconnecting state (dotnet#30948) * Changed logLevel to Information instead of warning for EphemeralDataProtectionProvider (dotnet#29405) Fixes dotnet#29107 * [Blazor][Desktop] Fixes nullable annotations on the public API baselines (dotnet#31073) * Fix nullable annotations * Fix APIs * Add missing API baseline file * Implements shadow copying for ASP.NET Core + IIS (dotnet#28357) * Suppress generating source checksums when configured (dotnet#31089) Hot reload / EnC does not like it when type level attributes are modified. Razor views and Pages include a RazorSourceChecksumAttribute that includes a checksum of all of it's inputs (current cshtml file, and all _ViewImports that contribute to it). It's used used by runtime compilation to tell if the compiled view is current compared to it's inputs. However, it gets in the way with enc since editing a file updates the checksum. We'll disable this feature by default in RazorSourceGenerator, and enable it using an MSBuild switch that's configured by runtime compilation * Caching Redis: Add option to register profiling session (dotnet#31018) * Add option to register profiling session * Add API change * Fix public API declaration * Cleanup * Quarantine and fix RequestTrailers_CanReadTrailersFromRequest dotnet#31057 (dotnet#31059) * Sync shared code from runtime (dotnet#31094) Co-authored-by: Tratcher <[email protected]> * Revert "Remove ANCM shim and outofprocess handler from Runtime SiteEx… (dotnet#31042) * Revert "Remove ANCM shim and outofprocess handler from Runtime SiteExtension (dotnet#24884)" This reverts commit 7f7528f. * Enable site extension build temporarily * Enable build native * Fixing site extension build * No need to set * Fixing up build * Update .azure/pipelines/ci.yml * Update ci.yml * retry * Update .azure/pipelines/ci.yml * Follow ups for Blazor AOT (dotnet#31098) * Follow ups for Blazor AOT * Add Emscripten packs to manifest * Update acquire tool to use manifest from the dotnet sdk * Add AOT option to templates * Undo Emscripten for now * [Blazor] [Desktop] Exclude Resources.resx from the embedded file manifest (dotnet#31107) Excludes unnecessary embedded resources from the embedded files manifest provider. * Fix some low hanging allocation fruit (dotnet#31115) * Fix some low hanging allocation fruit - Use singleton pipe options - Use Task.Yield instead of AwaitableThreadPool on the server side - Change WebSocketMiddleware handshake helpers to remove enumerator allocations. * Fix issues preventing hot reload for Blazor WASM (dotnet#31108) * Configure DOTNET_MODIFIABLE_ASSEMBLIES=debug env variable * Fixup broken reflection * Fixup targeting pack intermediate zip version * Add new Polly DI extension method for HttpClientFactory (dotnet#28283) * Fix IDE warnings Fix IDE warnings about non-disposed handlers. * Update return type documentation Update the comment's type to match the method's. * Add new AddPolicyRegistry overload Add a new overload for AddPolicyRegistry() that allows the caller to configure the policy registry using other services that are registered with the service provider, such as config. * Add more nullability to Mvc.Core (dotnet#31076) * Update nuget & msbuild versions (dotnet#31064) * Update nuget & msbuild versions * Update RepoTasks.csproj * Fix one test * Fix all tests * Update dependencies from https://github.com/dotnet/arcade build 20210317.3 (dotnet#31124) Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21167.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update branding to 6.0.0-preview4 * Revert "Update branding to 6.0.0-preview4" This reverts commit 5c8e9f1. * Added missing event ids for hosting events (dotnet#31149) - Fixed slnf file * Don't separately build arm64 installers * Don't build targeting pack nupkgs * Undo change that stopped building installers in win-arm64 leg. This reverts commit 03aab5d. * Update comment * Update branding to 6.0.0-preview4 (dotnet#31153) * Dispose the DiagnosticListener (dotnet#31170) - Add the DiagnosticListener to the DI container as a lambda so it gets disposed. * Add support for tabs vs. spaces settings for generated files * Fixed grammar on `SessionOptions.IOTimeout` XML (dotnet#31174) Fixed grammar on `SessionOptions.IOTimeout` * Resolve remaining credscan bugs (dotnet#31157) * Default to Kestrel over IISExpress (dotnet#31161) * Update CONTRIBUTING.md (dotnet#31167) * Update CONTRIBUTING.md * Follow-up edits * Add tracing to templates process launch for debugging (dotnet#31202) * Add tests * Cleanup * Cleanup * Remove unsafe from BytesOrdinalEqualsStringAndAscii (dotnet#31201) * Add field * Cleanup * Revert changes to global.json * fix naming * Add hotReloadProfile to Razor Pages template (dotnet#31197) * BlazorTemplate test improvements (dotnet#30907) * Split the HPackEncoder partial class (dotnet#31210) * [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#31020) [main] Update dependencies from dotnet/runtime dotnet/efcore - Do not declare iOS and Android support everywhere - runtime update includes new annotations making non-support obvious - see dotnet/runtime#49354 (w/ a similar Android PR coming soon) - !fixup! Fix typo in item group name - !fixup! Set `$(RemoveDevicePlatformSupport)` in correct project - not needed in BlazorManifest.csproj - but, is needed in dotnet-install-blazoraot.csproj - suppress - Fixup * Annotate Blazor wasm auth assemblies for trimmability (dotnet#31119) Minor cleanup when inspecting the code * Creates script command for sql-cache-tool (dotnet#30398) * Creates script command for sql-cache-tool * Includes idempotency, output to stdout, or specific file * Fixes help suggestion to be command-specific * Corrects typo * Revert "BlazorTemplate test improvements (dotnet#30907)" (dotnet#31223) This reverts commit 730e39b. * Sync shared code from runtime (dotnet#31182) Co-authored-by: dotnet <[email protected]> * Unquarantine BootResourceCachingTest (dotnet#31154) * Resolve final credscan bug (dotnet#31196) * READMEs for Servers (dotnet#31207) * READMEs for Servers * Remove en-us * Update src/Servers/README.md Co-authored-by: Brennan <[email protected]> * Update src/Servers/Kestrel/README.md Co-authored-by: Chris Ross <[email protected]> * Update src/Servers/IIS/README.md Co-authored-by: Chris Ross <[email protected]> * Feedback * Update src/Servers/HttpSys/README.md * Quick test * HttpSys * Update README.md * Feedback * Update src/Servers/IIS/README.md Co-authored-by: Günther Foidl <[email protected]> * Update src/Servers/Kestrel/README.md Co-authored-by: Günther Foidl <[email protected]> Co-authored-by: Brennan <[email protected]> Co-authored-by: Chris Ross <[email protected]> Co-authored-by: Günther Foidl <[email protected]> * Components test parole for good behavior (dotnet#31156) * Add hotReloadProfile to Razor Pages template (dotnet#31216) * Add hotReloadProfile to Razor Pages template * Turn off hotReloadProfile for Blazor WebAssembly projects The WebAssembly experience is a bit problematic in preview3 because of runtime issues dotnet/runtime#50190. We'll turn it off in the templates by default to avoid giving a confusing experience out of the box. * [main] Update dependencies from dotnet/efcore dotnet/runtime (dotnet#31220) [main] Update dependencies from dotnet/efcore dotnet/runtime * Readmes for HTTP and Site Extensions (dotnet#31250) * Readmes for HTTP and Site Extensions * Apply suggestions from code review Co-authored-by: Brennan <[email protected]> Co-authored-by: Brennan <[email protected]> * Update dependencies from https://github.com/dotnet/efcore build 20210325.2 (dotnet#31254) [main] Update dependencies from dotnet/efcore * Refactor and fix failing tests * Revert global.json changes * Enable CA2012 (Use ValueTask Correctly) (dotnet#31221) * Unquarantine a couple servers tests (dotnet#31213) * Update src/Razor/Microsoft.AspNetCore.Razor.Language/src/CodeGeneration/CodeWriter.cs Co-authored-by: Pranav K <[email protected]> * Sync shared code from runtime (dotnet#31271) Co-authored-by: Tratcher <[email protected]> * Update dependencies from https://github.com/dotnet/runtime build 20210326.1 (dotnet#31277) [main] Update dependencies from dotnet/runtime * Use Emscripten SDKs in WASM workload (dotnet#31259) * Update dependencies from https://github.com/dotnet/efcore build 20210326.1 (dotnet#31283) [main] Update dependencies from dotnet/efcore * Clean up verbiage on build scripts (dotnet#31262) * Clean up verbiage on build scripts * Update docs/BuildFromSource.md Co-authored-by: Kevin Pilch <[email protected]> Co-authored-by: Kevin Pilch <[email protected]> * Enable nullable on more authentication projects (dotnet#31230) * Enable nullable on Azure projects (dotnet#31298) * Reduce allocations for Cookies. (dotnet#31258) * Update dependencies from https://github.com/dotnet/efcore build 20210326.2 (dotnet#31292) [main] Update dependencies from dotnet/efcore * [release/6.0-preview3] Update dependencies from dotnet/efcore dotnet/runtime (dotnet#31255) [release/6.0-preview3] Update dependencies from dotnet/efcore dotnet/runtime - Port changes from main - Merge branch 'release/6.0-preview3' into darc-release/6.0-preview3-ce4fb228-ea32-4f60-95e1-0e60d42e3fc3 * [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#31310) [main] Update dependencies from dotnet/runtime dotnet/efcore * Update dependencies from https://github.com/dotnet/runtime build 20210327.4 (dotnet#31329) [main] Update dependencies from dotnet/runtime * Fix comment grammar (dotnet#31326) Minor update to XML docs to fix sentence grammar. * Use LoggerMessage.Define in HttpSys (dotnet#31333) - Use LoggerMessage.Define() throughout HttpSys instead of ILogger extension methods. - Also updates two incorrect event Id field names. Fixes dotnet#31313. * Reduce the per connection overhead in SocketConnection (dotnet#31308) * Reduce the per connection overhead in SocketConnection - Removed 3 state machines (StartAsync, ProcessSends and ProcessReceives) - Use ValueTask to remove delegate allocation on both senders and receivers - Remove field from DoSend and DoReceive state machine * Faster strongly typed features for server FeatureCollection (dotnet#31322) - Use strongly typed features - Use Unsafe.As to workaround dotnet/runtime#49614 - Do the casting it for Set<T> as well - Add more benchmarks - Reorder features (order of reset); * Update dependencies from https://github.com/dotnet/runtime build 20210328.6 (dotnet#31350) [main] Update dependencies from dotnet/runtime * Move logging to separate class to prevent allocation per generic type (dotnet#31345) * Badges, badges! (Licence, Help wanted, Good first issue, Chat) (dotnet#31341) * Badges, badges! (Licence, Help wanted, Good first issue, Chat) * Use correct links * Update dependencies from https://github.com/dotnet/efcore build 20210329.1 (dotnet#31351) [main] Update dependencies from dotnet/efcore * Fix WebView header APIs and behavior (dotnet#31246) * Fix WebView header APIs and behavior - Change WebView to return dictionary of headers instead of strings (this is needed for Android) - Change StaticContentProvider to use filename (always exists) instead of physical file path (not always available) to determine MIME type - Fix WPF sample bug * Update dependencies from https://github.com/dotnet/efcore build 20210329.2 (dotnet#31352) [main] Update dependencies from dotnet/efcore * Update dependencies from https://github.com/dotnet/efcore build 20210327.1 (dotnet#31309) [release/6.0-preview3] Update dependencies from dotnet/efcore * Update dependencies from https://github.com/dotnet/runtime build 20210329.3 (dotnet#31363) [release/6.0-preview3] Update dependencies from dotnet/runtime * Refactor logging in generic classes (dotnet#31364) * Update dependencies from https://github.com/dotnet/efcore build 20210329.4 (dotnet#31366) [release/6.0-preview3] Update dependencies from dotnet/efcore * Update dependencies from https://github.com/dotnet/efcore build 20210329.3 (dotnet#31353) [main] Update dependencies from dotnet/efcore * Make RequestDelegateFactory public (was MapActionExpressionTreeBuilder) (dotnet#31171) * Make RequestDelegateBuilder public - Formerly known as MapActionExpressionTreeBuilder * Add new BuildRequestDelegate overloads * Address PR feedback * RequestDelegateBuilder -> RequestDelegateFactory * Build -> Create * Address final review feedback. * [Http] Remove some unsafe code and save a string allocation (dotnet#31267) * Use one shot pbkdf2 (dotnet#31200) * Use one shot pbkdf2 * Update NetCorePbkdf2Provider.cs * CR feedback * CR feedback * Fix * Just use GetBytes for now * Update NetCorePbkdf2Provider.cs * Use interned Header Names for known headers not in the pre-allocated block (dotnet#31311) * Use interned headernames for known headers not in the preallocated block * Switch Connection header values for interned values * Use interned strings for websockets * Keep baggage, tracestate, and traceparent with previous casing * Update src/Servers/Kestrel/shared/KnownHeaders.cs Co-authored-by: Chris Ross <[email protected]> * Feedback Co-authored-by: Chris Ross <[email protected]> * Revert global.json changes * Modify constructor * Remove IReceiveHotReloadContext and HotReloadContext (dotnet#31281) * Remove IReceiveHotReloadContext and HotReloadContext React to API review feedback. Substitute IReceiveHotReloadContext and HotReloadContext with RenderHandle.IsHotReloading * Fixup * Update src/Components/Components/src/RenderHandle.cs * Update src/Components/Components/src/Properties/ILLink.Substitutions.xml * Update src/Components/Components/src/Properties/ILLink.Substitutions.xml * Flow Kestrel CancellationTokens to BindAsync (dotnet#31377) * Update dependencies from https://github.com/dotnet/runtime build 20210329.5 (dotnet#31384) [main] Update dependencies from dotnet/runtime * [main] Update dependencies from dotnet/arcade (dotnet#31349) [main] Update dependencies from dotnet/arcade * Quarantine flaky test (dotnet#31389) * Clean up NetCore PBKDF2 provider. (dotnet#31391) * Update dependencies from https://github.com/dotnet/runtime build 20210330.7 (dotnet#31394) [release/6.0-preview3] Update dependencies from dotnet/runtime * Add a FeaturesCollection constructor that supports initial capacity (dotnet#31381) * Add a FeaturesCollection constructor that supports initial capacity * Raise authenticationFailed event when cert validation fails (dotnet#31370) * Unquarantine UseStartupFactoryWorks (dotnet#31297) * Update dependencies from https://github.com/dotnet/efcore build 20210330.1 (dotnet#31400) [release/6.0-preview3] Update dependencies from dotnet/efcore * Update dependencies from https://github.com/dotnet/efcore build 20210330.2 (dotnet#31401) [main] Update dependencies from dotnet/efcore * Fix generated CSS scopes in layout views and update templates (dotnet#31257) * Fix generated CSS scopes in layout views and update templates * Update template baselines * Enabled scoped CSS for MVC template tests * Bring back static CSS file * Quarantine ClosesAfterDataSent (dotnet#31405) * Update CONTRIBUTING.md (dotnet#31371) Removed tab that seemed to cause a paragraph about the new help wanted label to be in a code fence. * Support round trip serialization of AuthenticationProperties with System.Text.Json (dotnet#31330) dotnet#20722 * Update Microsoft.Net.Compilers.Toolset (dotnet#31403) * Improve test failures for unexpected logs (dotnet#31406) * Add ToString() to Testing's log WriteContext * Update StrictTestServerTests to only show unexpected log * Undo template change that induced flakiness (dotnet#31417) * Add helpful exception message when exception handler returns 404 (dotnet#31142) * Update dependencies from https://github.com/dotnet/runtime build 20210331.6 (dotnet#31421) [release/6.0-preview3] Update dependencies from dotnet/runtime * Do not serialize Parameters property on AuthenticationProperties (dotnet#31414) * Do not serialize Parameters Explicitly prevent the Parameters dictionary from being included in the deserialized payload. See dotnet#31330 (comment). * Ignore props backed by Items Also ignore the properties backed by the Items dictionary to minimise the size of the serialized JSON payload. * Add ignoreLineEndingDifferences Stop tests from failing on non-Windows OSs due to different line endings. * ArPow stage 1: local source-build infrastructure (dotnet#31235) Conflicts: eng/Version.Details.xml Co-authored-by: John Luo <[email protected]> * [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#31411) [main] Update dependencies from dotnet/runtime dotnet/efcore * Update dependencies from https://github.com/dotnet/efcore build 20210331.4 (dotnet#31424) [release/6.0-preview3] Update dependencies from dotnet/efcore * Fix project path in slnf (dotnet#31431) * Fix trailing comma in Caching.slnf (dotnet#31438) * Fix file headers in src/Caching (dotnet#31439) * [SignalR Java] Update to RxJava3 (dotnet#31426) * Fixed de-duping hosting startup assemblies (dotnet#31440) - De-dupe hosting startup assemblies based on assembly instance not the name of the assembly. Names can be short or long and we don't know if they resolve to the same assembly. Instead of trying to mess with names, we just check to make sure that the instance isn't the same. * Trim down framework references for Blazor dev server (dotnet#31420) * Only include Microsoft.AspNetCore.App framework reference for Blazor dev server * Address feedback from peer review * Use SharedFxVersion property * Cross-target last few projects to DefaultNetCoreTargetFramework (dotnet#31239) * Cross-target last 2 projects to DefaultNetCoreTargetFramework * More projects * Fixup * Fixup again * Fixup * Undo SiteExtension change * Update src/SiteExtensions/LoggingBranch/LB.csproj Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: Doug Bunting <[email protected]> * [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#31425) [main] Update dependencies from dotnet/runtime dotnet/efcore * Use integer division trick to get exact base64 length (dotnet#31442) * Add nullability to more MVC assemblies (dotnet#31338) * Add nullability to more MVC assemblies * [x] MVC.Cors * [x] Mvc.DataAnnotations * [x] Mvc.Localization * [x] Mvc.Newtonsoft.Json * [ ] Mvc.ViewFeatures (partial) * Fixup * Update src/Mvc/Mvc.ViewFeatures/src/Rendering/ViewContext.cs * Apply suggestions from code review * Update RazorPagePropertyActivator.cs * Update assembly check on EventHandlerTagHelperDescriptorProvider (dotnet#31458) * Remove legacy routing (dotnet#31295) * [release/6.0-preview3] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#31451) [release/6.0-preview3] Update dependencies from dotnet/runtime dotnet/efcore * Update dependencies from https://github.com/dotnet/arcade build 20210331.6 (dotnet#31427) [main] Update dependencies from dotnet/arcade - Merge branch 'main' into darc-main-2c400715-e553-48d8-8d43-983dc7aa4b7d * Update dependencies from https://github.com/dotnet/efcore build 20210401.3 (dotnet#31468) [main] Update dependencies from dotnet/efcore * Fix project paths in Azure.slnf (dotnet#31435) * Fix project paths in Azure.slnf * Update Azure.slnf * Update IdentityModel versions to 6.10.0 dotnet#31454 (dotnet#31482) * Removed static activity source from hosting (dotnet#31483) * Removed static activity source from hosting - Get it from DI instead * Fixed test * Use Random.Shared property (dotnet#31453) * Use Random.Shared Use the new .NET 6 Random.Shared static property where possible. See dotnet/runtime#50297. * Revert WebApi-CSharp changes For some reason I don't understand, this template doesn't see Random.Shared when compiled so this reverts the previous change for this template. * Remove baseline suppressions from 5.0 (dotnet#29934) * Remove baseline suppressions from 5.0 * Use newer NuGet.Protocol version - v4.8.2 ➡️ v5.8.1 * Fix condition * Back to 5.8.1 * Undo components changes * Whoops * Whoops Co-authored-by: Doug Bunting <[email protected]> * Remove DNT from pre-reserved headers (dotnet#31493) No modern browser uses it anymore * Reuse HttpProtocol CTS (dotnet#31466) * Change Router _emptyParametersDictionary to a regular Dictionary (dotnet#31460) * Change Router _emptyParametersDictionary to a regular Dictionary This allows for ReadOnlyDictionary to be trimmed in a default Blazor WASM app. Saving roughly 3 KB .br compressed. Contributes to dotnet#30098 * Update src/Components/Components/src/Routing/Router.cs Co-authored-by: James Newton-King <[email protected]> * Clean up some MVC code (dotnet#31511) * Clean up some MVC code * PR feedback * Do not throwing on InputBase.Dispose() if not in EditContext. (dotnet#31510) * Do not throwing on InputBase.Dispose() if not in EditContext. Fixes dotnet#30990 * Cache filters between requests in the ordinary case (dotnet#31513) In the normal case, * only the DefaultFilterFactoryProvider is registered * all filters registered by the framework are reusable We could so something targeted and cache filter instances between requests. * Update dependencies from https://github.com/dotnet/arcade build 20210403.1 (dotnet#31526) [main] Update dependencies from dotnet/arcade * Flaky tests (dotnet#31502) * Revert "Update assembly check on EventHandlerTagHelperDescriptorProvider (dotnet#31458)" (dotnet#31530) This reverts commit 7bc87ba. * Ability to deactivate DataAnnotationsValidation dynamically. Fixes dotnet#31027 (dotnet#31413) * Use UriHelper.BuildAbsolute for RedirectToHttpsRule (dotnet#28899) * Use UriHelper.BuildAbsolute and UriHelper.BuildRelative for RedirectRule (dotnet#28903) * Still send 100 Continue with null MinRequestBodyDataRate (dotnet#31543) * Update Selenium/Playwright (dotnet#31497) * Update Selenium/Playwright * Update selenium-config.json * Update Versions.props * Added VSCode debugging (for MvcSandbox) & code analysis support (dotnet#29486) * Added VSCode debugging support for MvcSandbox * Added ignored vscode folders * 1. Convered some more projects. 2. Added env variable for TargetFramework and used it in launch.json file rather than hardcoding TFW. * Addressed PR feedback. 1. Removed extensions.json 2. Updated BuildFromSource.md for Vscode instructions. 3. Added launch settings for BasicTestApp. * Addressed PR feedback! * Implement new SmallCapacityDictionary for dictionaries with a small amount of values. (dotnet#31360) * Fix duplicated event names in KestrelTrace logger. (dotnet#31523) (dotnet#31554) * Update area-owners.md (dotnet#31552) * Data Protection minor tidying (dotnet#31512) * Remove unused code Remove unused constant, method and variable. * Remove array allocations Use Array.Empty() instead of allocating an empty array. Use a static array for activation type instead of creating a new one per invocation. * Rename field Address PR feedback. * [SignalR TS] Improve connection error messages (dotnet#31402) * [MVC] Fix MSB4186 error (dotnet#31066) Fix MSB4186 error if a project references Microsoft.AspNetCore.Mvc.Testing that is not itself an ASP.NET project, such as a helper library in a test suite. * Re-use cancellation tokens in the https middleware (dotnet#31528) * Re-use cancellation tokens in the https middleware - These tokens are usually short lived and exist for the purposes of cancelling the handshake. * Fix IPNetwork.Contains behavior for prefixes which are not at start of subnet range (dotnet#31573) * Update branding to 5.0.6 (dotnet#31563) * Use skipEnabledCheck for LoggerMessage.Define (dotnet#31562) * Use skipEnabledCheck in MVC * Use skipEnabledCheck in Http/Routing DefaultLinkGenerator, DefaultLinkParser, and DfaMatcher * Use skipEnabledCheck in SignalR * Use skipEnabledCheck in Components * Use skipEnabledCheck in Hosting * Use skipEnabledCheck in Servers/HttpSys * Use skipEnabledCheck in Servers/Kestrel * Use skipEnabledCheck in Middleware * Avoid some allocations by checked IsEnabled first in MVC * Avoid some allocations by checked IsEnabled first in Servers/Kestrel * Simplify usage of logging in transports * Fix up typo in Blazor Server launchSettings.json (dotnet#31580) * Rename 'Blazor component' to 'component' to be more generic (dotnet#31590) Co-authored-by: Adrian Wright <[email protected]> * Update branding to 3.1.15 (dotnet#31577) * Update branding to 3.1.15 Update Ubuntu 16.04 to 18.04 * Remove obsolete groovy code * [release/5.0] Update nuget versions (dotnet#31490) * Update nuget/msbuild versions * Update nuget * Nuget only * Fix baseline, update to 5.8.1 * Undo test change * Update MetadataSerializerTest.cs * Set cab name for TargetingPack.wixproj (dotnet#30975) * Added IConnectionSocketFeature (dotnet#31588) - Removed the nullable from the Socket property as approved in API review - Make the IConnectionSocketFeature an additional feature instead of one implemented on the TransportConnection. - Added a test to verify it works * Fix null ref in SyntaxTokenCache (dotnet#30978) (dotnet#30988) Fixes dotnet#27154 * Still send 100 Continue with null MinRequestBodyDataRate (dotnet#31568) * [SignalR TS] Fix permanent Disconnecting state (dotnet#30948) (dotnet#31253) * Fix arguments order for call of HeartbeatSlow (dotnet#28698) (dotnet#31080) Co-authored-by: Roman Marusyk <[email protected]> * Quarantine one failing test (dotnet#31045) (dotnet#31296) - dotnet#31044 - `RazorPagesTemplate_RazorRuntimeCompilation_BuildsAndPublishes()` Co-authored-by: Doug Bunting <[email protected]> * Fix merge * Fix merge * Update HubConnection.Reconnect.test.ts * Update default-build.yml * Error boundaries (dotnet#30874) * Remove unused ADAL dependency (dotnet#31484) * Remove unused dependency * Remove outdated AAD sample * Custom event args: support receiving IJSObjectReference (dotnet#31591) * Add failing E2E case * Implement fix * Add E2E test * Update src/Components/test/testassets/BasicTestApp/EventCustomArgsComponent.razor * Update suppressions * [SignalR TS] Set keep alive timer in receive loop (dotnet#31300) * Unskip some fixed E2E tests (dotnet#31614) * Fix "no event handler" in simultaneous blur+removal case (dotnet#31612) * [SPA] Introduces new approach for proxying the SPA templates (dotnet#31564) * A new package Microsoft.AspNetCore.SpaProxy has been added that is used by the templates to launch their development proxy via npm/yarn. * The SPA development proxy for each CLI now is the frontend for the application and proxies the requests to the backend which is the ASP.NET Core application. * At publish time the application assets are copied to the wwwroot. * SpaServices.Extensions has been removed from the templates since it is no longer needed. MapFallbackToFile("index.html") handles unknown requests and serves the SPA entry point. * The templates have been updated to keep using HTTPS with the SPA proxy configured to use the ASP.NET Core HTTPS development certificate via a new aspnetcore-https.js file that ships within the template. * The configuration for angular has been updated with a proxy.conf.js file to proxy requests to the backend. * The entry point for the application in development is now https://localhost:5002 when using https and http://localhost:5002 otherwise. * Infer default sources for parameters of minimal actions (dotnet#31603) This does a big chunk of dotnet#30248 while heavily refactoring the RequestDelegateFactory by splitting it out into a bunch of smaller methods. For part 2 of dotnet#30248, a "scalar value type that lives in the System namespace", I went with the alternative of "Something convention-based like the presence of a bool TryParse(string, out T) method" instead. This conventions work for types in any namespace including user-defined types. * Avoid closure caused by local function (dotnet#31641) * Avoid closure caused by local function - Made the local function static and passed state via parameters. * Remove form support from minimal APIs (dotnet#31646) * Remove form support from minimal APIs * Add * MapActionSample -> MinimalSample * Remove MapActionSample.csproj from Mvc.slnf * [Templates] Update the react template to use the CLI proxy (dotnet#31652) Updates the react template to use the http-proxy-middleware for handling the requests instead of the asp.net core proxy in the same way it's done for the Angular template. * [SignalR] Allocate HubCallerClients once per connection (dotnet#31661) * [main] Update dependencies from dotnet/emsdk dotnet/efcore dotnet/runtime (dotnet#31576) [main] Update dependencies from dotnet/emsdk dotnet/efcore dotnet/runtime - Add `RemoveDevicePlatformSupport` To `Microsoft.AspNetCore.Authentication.Negotiate.csproj` Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Andre Milbradt <[email protected]> Co-authored-by: Andre Milbradt <[email protected]> Co-authored-by: Pranav K <[email protected]> Co-authored-by: Hao Kung <[email protected]> Co-authored-by: David Fowler <[email protected]> Co-authored-by: Safia Abdalla <[email protected]> Co-authored-by: Kristian Hellang <[email protected]> Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: James Newton-King <[email protected]> Co-authored-by: Chris Ross <[email protected]> Co-authored-by: Steve Sanderson <[email protected]> Co-authored-by: Kevin Pilch <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: N. Taylor Mullen <[email protected]> Co-authored-by: Eilon Lipton <[email protected]> Co-authored-by: Brennan <[email protected]> Co-authored-by: Shreyas Jejurkar <[email protected]> Co-authored-by: Justin Kotalik <[email protected]> Co-authored-by: Gabriel Lucaci <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tratcher <[email protected]> Co-authored-by: John Luo <[email protected]> Co-authored-by: Martin Costello <[email protected]> Co-authored-by: William Godbe <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Allison Chou <[email protected]> Co-authored-by: Anthony J <[email protected]> Co-authored-by: Jonathan Berube <[email protected]> Co-authored-by: dotnet <[email protected]> Co-authored-by: Günther Foidl <[email protected]> Co-authored-by: Stephen Toub <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Andrzej <[email protected]> Co-authored-by: Stephen Halter <[email protected]> Co-authored-by: Kevin Jones <[email protected]> Co-authored-by: Marek Linka <[email protected]> Co-authored-by: Kevin Miller <[email protected]> Co-authored-by: Michael Simons <[email protected]> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: fvoronin <[email protected]> Co-authored-by: Paulo Morgado <[email protected]> Co-authored-by: Tanay Parikh <[email protected]> Co-authored-by: Adrian Wright <[email protected]> Co-authored-by: Adrian Wright <[email protected]> Co-authored-by: Sébastien Ros <[email protected]> Co-authored-by: Roman Marusyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft based on offline discussions. I was able to plug this in to an app and verify this implementation works at least for the templates. I'll try and get some rudimentary tests added for this soon