Don't log a stack trace for AddressInUseException

[BerserkerDotNet]

In case of AddressInUseException do not log the exception
AddressInUseException:

Other exceptions:

Addresses #29801

[dnfadmin]

All CLA requirements met.

[davidfowl]

Wait why are we taking this change? Isn't this in the wrong layer? Removing information from loggers is the wrong place to do this sort of filtering.

[BerserkerDotNet]

Wait why are we taking this change? Isn't this in the wrong layer? Removing information from loggers is the wrong place to do this sort of filtering.

Won't argue, it looks weird at best. :) But my understanding is #29801 asks to remove this information from the log without suppressing the exception. (See #29801 (comment)) Maybe I misunderstood the ask.

[BrennanConroy]

Triage: We think we shouldn't log and just let the exception flow up to the user.

[BerserkerDotNet]

Triage: We think we shouldn't log and just let the exception flow up to the user.

Ok, I'll make that change.

[BerserkerDotNet]

@BrennanConroy, done. Updated PR description as well.

[halter73]

@davidfowl Was your suggestion to no longer log any startup exceptions in KestrelServer? It feels wrong to log everything except AddressInUseExceptions.

[davidfowl]

Yep, don't log anything here. Just rethrow the exception.

[halter73]

Thanks @BerserkerDotNet!

[maxcherednik]

@davidfowl I guess we addressed one of the issues mentioned here: #29801

To be specific - log and throw issue.

There was another issue, which is bigger than the one addressed in this pr.

Can we please consider reopening the issue?

[ghost]

Hi @maxcherednik. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[davidfowl]

@maxcherednik , open a new issue please with details.