Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/5.0] Work around nginx installation failure #28524

Closed
wants to merge 4 commits into from
Closed

[release/5.0] Work around nginx installation failure #28524

wants to merge 4 commits into from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Dec 8, 2020 •
edited
Loading

Manually uninstall/delete openssl until https://github.com/dotnet/core-eng/issues/11636 is resolved

@wtgodbe wtgodbe requested review from Pilchie and a team December 8, 2020 22:25
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 8, 2020
@wtgodbe wtgodbe mentioned this pull request Dec 8, 2020
Closed
@BrennanConroy
Copy link
Member

Have we considered the workaround instead?
actions/runner-images#1811 (comment)

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 8, 2020

Oh nice, I hadn't seen that - giving it a try: 44b8a67

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 8, 2020

That worked! Thanks @BrennanConroy

@wtgodbe wtgodbe changed the title [release/5.0] Temporarily disable OSX test job [release/5.0] Work around nginx installation failure Dec 8, 2020
MattGal
MattGal reviewed Dec 8, 2020
View reviewed changes
.azure/pipelines/ci.yml Outdated Show resolved Hide resolved
MattGal
MattGal approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it'll work.

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@BrennanConroy
Copy link
Member

From latest email

You should be able to use brew as normal again in Hosted MacOS build machines;

Think we can close this.

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 9, 2020

Think we can close this.

Yep - I think the Helix test failure is real, though, so I'm using the CI job to look into it. Will close this and replace with another PR to fix the test once I figure it out

@BrennanConroy
Copy link
Member

A template test hang on Ubuntu. I tried to open it in VS (since that is supposedly supported now), but failed :(

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 9, 2020

I saw the same thing in another PR, which is why I thought it was real, but maybe it's transient. I'll retry here, and kick the other servicing-approved 5.0 PRs just in case.

@wtgodbe wtgodbe closed this Dec 9, 2020
@wtgodbe wtgodbe deleted the wtgodbe/DisableOSXTest branch December 9, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGal MattGal MattGal approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @BrennanConroy @MattGal