Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support primitive type/classes in HubConnection.on() #25773

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Support primitive type/classes in HubConnection.on() #25773

merged 3 commits into from
Sep 11, 2020

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 10, 2020

Fixes #25088

Changes the .on() method so that it handles casting to primitives, similar to what we already do in invoke() and stream(). Also changes tests to test that this new behavior works.

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Sep 10, 2020
@wtgodbe wtgodbe added this to the 5.0.0-rc2 milestone Sep 10, 2020
BrennanConroy
BrennanConroy approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/Utils.java Outdated Show resolved Hide resolved
src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/Utils.java Outdated Show resolved Hide resolved
src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/Utils.java Outdated Show resolved Hide resolved
@wtgodbe wtgodbe added the Servicing-consider Shiproom approval is required for the issue label Sep 11, 2020
@ghost
Copy link

ghost commented Sep 11, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 11, 2020

@Pilchie can we take this for rc2? It fixes a bug where customers couldn't use primitive types in the on handlers of the java SignalR client (instead they had to use wrapper classes, e.g. Integer.class instead of int.class).

@Pilchie Pilchie added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 11, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 11, 2020

Approved for .NET 5 RC2.

@wtgodbe wtgodbe merged commit 77be06a into release/5.0-rc2 Sep 11, 2020
@wtgodbe wtgodbe deleted the wtgodbe/onPrim branch September 11, 2020 17:11
@wtgodbe wtgodbe mentioned this pull request Sep 11, 2020
Closed
@runfoapp runfoapp bot mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 halter73 approved these changes

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
5.0.0-rc2
Development

Successfully merging this pull request may close these issues.
4 participants
@wtgodbe @Pilchie @halter73 @BrennanConroy