Enable Kestrel config reload in ConfigureWebHostDefaults #22528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR to enable reloadable Kestrel config (#21072) originally changed the behavior of the existing
KestrelServerOptions.Configure(IConfiguration)
method to support reloading config and added a new overload to opt out. We decided that was too breaking, so we switched it to opt in.I think that changing the behavior of ConfigureWebHostDefaults is worth the break though. ConfigureWebHostDefaults already calls AddJsonFile with reloadOnChange set to true, so having Kestrel reloadOnChange is more consistent. I also find it unlikely that it's common to change Kestrel config and expect Kestrel not to react to it.
I'm targeting preview6 so we can get feedback on this change earlier.