Add file manifest for runtime and targeting pack #11235
Conversation
jkotalik
added
the
feature-platform
|
@dsplaisted I think I need to run this PR by you to make sure I'm producing the right manifests in the correct locations. |
jkotalik
force-pushed
the
jkotalik/frameworkList
branch
from
9aacd76 to
92a3a5c
Compare
|
Verified the targeting pack and the runtime pack work locally. For the runtime pack, I change the KnownFrameworkReference to a local dev build of the M.A.App.Runtime.win-x64 and made sure restore/build worked. dotnet run failed from I'll be on top of verifying this once it gets merged into core-sdk and can react quickly. |
| @@ -100,6 +100,9 @@ This package is an internal implementation of the .NET Core SDK and is not meant | |||
| <RuntimePackageRoot>$([MSBuild]::EnsureTrailingSlash('$(RuntimePackageRoot)'))</RuntimePackageRoot> | |||
| <CrossgenToolPath>$([System.IO.Path]::Combine('$(RuntimePackageRoot)', 'tools', '$(CrossgenToolPackagePath)'))</CrossgenToolPath> | |||
| <AssetTargetFallback>$(AssetTargetFallback);native,Version=0.0</AssetTargetFallback> | |||
|
|
|||
| <FrameworkListFileName>RuntimeList.xml</FrameworkListFileName> | |||
| <FrameworkListOutputPath>$(ArtifactsObjDir)$(FrameworkListFileName)</FrameworkListOutputPath> | |||
There was a problem hiding this comment.
nit: FrameworkList => RuntimeList. these are different files so the property names should probably follow suite.
There was a problem hiding this comment.
How much do you care about this? PR is green and I'd rather not wait another 2 hours for a rebuild on a rename like this if you have no other feedback.
ghost
deleted the
Fixes #10215 and #10216
This seems to be working locally for win-x64. I want to confirm things look good on CI before I do some finalization.
Few open questions that I'm working on solving:
I'd also like to add a few automated tests once I confirm things are correct.