Work around potential race in PipeWriter (IIS Edition) #11165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
force-pushed
the
halter73/8843-iis
branch
from
aa128c4 to
e8c3d21
Compare
|
Got some build errors there 😮 |
halter73
force-pushed
the
halter73/8843-iis
branch
from
e8c3d21 to
236434d
Compare
|
Maybe I should try building before submitting my PR next time 😆 |
|
But that's what The ☁️ is for ;) |
halter73
force-pushed
the
halter73/8843-iis
branch
from
236434d to
6a3f573
Compare
jkotalik
reviewed
Jun 14, 2019
| } | ||
|
|
||
| private async Task FlushAsyncAwaited(ValueTask<FlushResult> awaitable, CancellationToken cancellationToken) | ||
| private Task FlushNowAsync(PipeWriter pipeWriter, CancellationToken cancellationToken) |
There was a problem hiding this comment.
FlushNow is... an interesting name. I can't think of anything better.
jkotalik
approved these changes
Jun 14, 2019
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should wait until #11065 (the Kestrel version of this) is merged and stable. If everything looks good for the Kestrel change, and it didn't have to detrimental of an impact to our benchmarks, I think we should take this despite the lack of IIS-related customer reports so far.
@jkotalik @davidfowl @pakrym if you're still interested.