Move all of DataProtection and Extensions.Identity to netstandard2.0 #11008

HaoK · 2019-06-07T23:08:33Z

First part of #3774 this will allow Extensions.Identity.Core Stores, and a few parts of data protection to target netstandard 2.0

HaoK · 2019-06-07T23:13:51Z

@natemcmaster @blowdart this seems a bit scary as the NetCorePbkdf2Provider provider is using a netcore DeriveBytes API, I only started with a few of the DP.abstractions packages and KeyDerivation which is the main thing that Identity needs for the password hasher.

I also reverted the Apr 26 PR that switched the password hasher to use CryptographicOperations.FixedTimeEquals (2b2aeee)

natemcmaster

Good start, but let's use cross compiling to keep existing improvements.

...ection/Cryptography.KeyDerivation/src/Microsoft.AspNetCore.Cryptography.KeyDerivation.csproj

src/DataProtection/Cryptography.KeyDerivation/src/PBKDF2/NetCorePbkdf2Provider.cs

src/Identity/Extensions.Core/src/PasswordHasher.cs

src/Identity/Extensions.Core/src/Microsoft.Extensions.Identity.Core.csproj

src/Identity/Extensions.Core/src/PasswordHasher.cs

HaoK · 2019-06-08T05:44:11Z

Okay so I took a stab at switching DP to netstandard and the issue is the IStartupFilter (this comes from AspNetCore.Hosting.Abstractions and not Extensions.Hosting.Abstractions) that gets added as part of AddDataProtection()

           services.TryAddEnumerable(ServiceDescriptor.Singleton<IStartupFilter, DataProtectionStartupFilter>());

Was there any prior discussion about how this should be resolved?

HaoK · 2019-06-11T21:58:21Z

@natemcmaster @ajcvickers what do you guys think about merging the identity + some of dataprotection changes since this at least enables extensions identity + dp abstractions / keyderivations to be used on netstandard 2.0. I can open another PR addressing the gnarly hosting + DP when we have agreed on an approach

natemcmaster · 2019-06-12T00:12:36Z

Discussed briefly with @ajcvickers.

I'm okay merging the changes in this PR as long as you update the description to remove the "fixes #3774" description. The goal of #3774 was to support packages which are both .NET Standard and do not have a dependency on the .NET Core shared framework, and this PR doesn't yet satisfy that criteria. To complete that issue, you'll need to address the DP -> Hosting dependency. Here are my thoughts on ways you might solve this: #3774 (comment).

Also, to make the packages available as packages, you need to set <IsShippingPackage> in the .csproj file, otherwise the assemblies will still be shared-framework only.

HaoK · 2019-06-12T05:13:14Z

Removed fix comment and added <IsShippingPackage>true</IsShippingPackage

HaoK · 2019-06-18T18:14:40Z

src/Shared/WebEncoders/WebEncoders.cs

@@ -2,7 +2,9 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

 using System;
+#if NETCOREAPP3_0


FYi @BrennanConroy I had to add this guard around the using buffers introduced from the spanify web encoders change last week since it isn't available in netstandard 2.0

Makes sense 👍

HaoK · 2019-06-18T18:16:01Z

This should now fix #3774 pending the resolution of IHostedService not running before the server starts :(

src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj

Tratcher · 2019-06-18T20:57:20Z

This should now fix #3774 pending the resolution of IHostedService not running before the server starts :(

In WebHost IHostedServices are started just after the server. In generic Host the web app is an IHostedService and they're started in registration order. Try testing with generic host to make sure you can get the ordering right. For WebHost it looks like IHostedServices is better than first-request, but not quite as good as IStartupFilter.

This reverts commit 2b2aeee.

…pNetCore.Cryptography.KeyDerivation.csproj Co-Authored-By: Nate McMaster <[email protected]>

Co-Authored-By: Nate McMaster <[email protected]>

…aProtection.csproj Co-Authored-By: Doug Bunting <[email protected]>

HaoK · 2019-06-21T20:17:53Z

Figured out the diff was trailing whitespace in the sharedframework.local...grrr

…to data-netstd

HaoK · 2019-06-21T21:38:38Z

Per offline thread with @Tratcher and @davidfowl this seems good enough for preview 7, will tweak in subsequent PRs as needed

Eilon added the area-dataprotection Includes: DataProtection label Jun 7, 2019

natemcmaster suggested changes Jun 8, 2019

View reviewed changes

HaoK marked this pull request as ready for review June 12, 2019 05:12

HaoK requested a review from a team as a code owner June 12, 2019 05:12

HaoK force-pushed the data-netstd branch from 2bfb9c5 to c3aa117 Compare June 18, 2019 17:59

BrennanConroy requested review from analogrelay, BrennanConroy, dougbu, halter73, jkotalik, mikaelm12, ryanbrandenburg, SteveSandersonMS and Tratcher as code owners June 18, 2019 17:59

HaoK commented Jun 18, 2019

View reviewed changes

HaoK changed the title ~~Move pieces of DataProtection and Identity to netstandard2.0~~ Move all of DataProtection and Extensions.Identity to netstandard2.0 Jun 18, 2019

dougbu requested changes Jun 18, 2019

View reviewed changes

src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj Show resolved Hide resolved

Tratcher mentioned this pull request Jun 18, 2019

Consider moving ASP.NET Core Data Protection to Microsoft.Extensions.* #3774

Closed

HaoK and others added 5 commits June 19, 2019 14:23

Revert "Use CryptographicOperations.FixedTimeEquals (#9798)"

2675203

This reverts commit 2b2aeee.

Switch some of DP and Identity.Core to netstandard 2.0

80e86b4

Move stores to netstandard2.0

e7d5f09

Update src/DataProtection/Cryptography.KeyDerivation/src/Microsoft.As…

16a5e10

…pNetCore.Cryptography.KeyDerivation.csproj Co-Authored-By: Nate McMaster <[email protected]>

Update src/Identity/Extensions.Core/src/PasswordHasher.cs

bcd4b8e

Co-Authored-By: Nate McMaster <[email protected]>

HaoK and others added 23 commits June 21, 2019 13:15

Update a bunch of refs

f5ee4ea

Put dataprotection back to netcoreapp3.0 for now so things build

9621ae1

Update refs

4bd9102

Update Microsoft.AspNetCore.DataProtection.Abstractions.csproj

9e762b8

Update Microsoft.AspNetCore.Cryptography.Internal.csproj

4e87ea9

Update Microsoft.AspNetCore.Cryptography.KeyDerivation.csproj

45e22af

Update Microsoft.Extensions.Identity.Core.csproj

5e835aa

Update Microsoft.Extensions.Identity.Stores.csproj

4293c95

Update Microsoft.AspNetCore.DataProtection.Abstractions.csproj

2a0a816

Update Microsoft.AspNetCore.DataProtection.Abstractions.csproj

5f42399

Switch Startup filter to HostedService

4a52b3b

Update refs

b768a6d

Remove netcoreapp ref

6b5aab2

Update all the rest of the packages to netstandard2/2.1

91ab870

Update src/DataProtection/DataProtection/src/Microsoft.AspNetCore.Dat…

83a0f23

…aProtection.csproj Co-Authored-By: Doug Bunting <[email protected]>

Update SharedFramework.Local.props

dac155a

Update Microsoft.AspNetCore.DataProtection.Extensions.csproj

93fc8cc

Update SharedFramework.Local.props

e52ae2e

Add generic host key ring loading test

35a495e

Start hosted services before server

e4c4210

Add ConfigureWebHost to generic test

5649460

Supressbaseline references

0f10e30

Update Microsoft.Extensions.Identity.Stores.csproj

1945c83

HaoK added 2 commits June 21, 2019 13:18

Fix whitespace

478a5ea

Merge branch 'data-netstd' of https://github.com/aspnet/AspNetCore in…

d9d7d0d

…to data-netstd

HaoK merged commit f35564b into master Jun 21, 2019

ghost deleted the data-netstd branch June 21, 2019 21:40

HaoK mentioned this pull request Sep 16, 2019

Investigate TFMs of Microsoft.AspNetCore.Cryptography.KeyDerivation #14023

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move all of DataProtection and Extensions.Identity to netstandard2.0 #11008

Move all of DataProtection and Extensions.Identity to netstandard2.0 #11008

HaoK commented Jun 7, 2019 •

edited

Loading

HaoK commented Jun 7, 2019

natemcmaster left a comment

HaoK commented Jun 8, 2019 •

edited

Loading

HaoK commented Jun 11, 2019

natemcmaster commented Jun 12, 2019

HaoK commented Jun 12, 2019

HaoK Jun 18, 2019

BrennanConroy Jun 18, 2019

HaoK commented Jun 18, 2019

Tratcher commented Jun 18, 2019

HaoK commented Jun 21, 2019

HaoK commented Jun 21, 2019

Move all of DataProtection and Extensions.Identity to netstandard2.0 #11008

Move all of DataProtection and Extensions.Identity to netstandard2.0 #11008

Conversation

HaoK commented Jun 7, 2019 • edited Loading

HaoK commented Jun 7, 2019

natemcmaster left a comment

Choose a reason for hiding this comment

HaoK commented Jun 8, 2019 • edited Loading

HaoK commented Jun 11, 2019

natemcmaster commented Jun 12, 2019

HaoK commented Jun 12, 2019

HaoK Jun 18, 2019

Choose a reason for hiding this comment

BrennanConroy Jun 18, 2019

Choose a reason for hiding this comment

HaoK commented Jun 18, 2019

Tratcher commented Jun 18, 2019

HaoK commented Jun 21, 2019

HaoK commented Jun 21, 2019

HaoK commented Jun 7, 2019 •

edited

Loading

HaoK commented Jun 8, 2019 •

edited

Loading