-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder.WebHost.UseUrls does not seem to override default url #38185
Comments
This is a bug. Certain Server urls are bound late enough that this should work as is. Unfortunately there's a bug where stale hosting config is incorrectly overriding the urls configured with There are a number of workarounds depending on your requirements. The easiest is likely passing in the app.Run("http://*:8080"); |
I think we should also patch this in 6.0.x |
I agree it should be patched. I almost milestoned it myself, but figured we could discuss in triage. |
Oof... so glad I came across this! I spent a whole day trying to figure out why my service wasn't working in my container and this was 100% it haha! |
For me, trying to override the URL in Run results in the following Setting |
Do you have a code snippet to share? |
This issue also affects setting the Works in 3.1 (listens on
Workaround for 6.0 (listens on
|
…lt hosting config ## Description Prior to this change, default config (typically loaded from `DOTNET_`/`ASPNET_` environment variables and command line arguments) could override the application-level configuration. This would prevent `GenericWebHostService` from seeing the latest configuration set by `UseUrls()` of `DOTNET_URLS`, `ASPNET_URLS` or `--urls` was set. Fixes dotnet#38185 ## Customer Impact This is a big gotcha to customers using `WebApplicationBuilder` (which is used in all the ASP.NET Core 6 templates) who expect the following to work: ```C# var builder = WebApplication.CreateBuilder(args); builder.WebHost.UseUrls("http://*:8080"); var app = builder.Build(); app.Run(); ``` A comment on the issue suggesting we patch this has gotten 5 thumbs ups not counting mine. ## Regression? - [ ] Yes - [x] No ## Risk - [ ] High - [ ] Medium - [x] Low This is a small well tested change which only affects the loading of default config sources and those added via a `HostFactoryResolver` to host configuration. [Here’s the existing test](https://github.com/dotnet/aspnetcore/blob/0f6f649f1da658bbe37b8898df0c80c5affa9d2d/src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs#L883) showing that the expected configuration providers are still dispose. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A
* [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-runtime * Merged PR 21649: [internal/release/6.0] Make UseUrls() override default hosting config ## Description Prior to this change, default config (typically loaded from `DOTNET_`/`ASPNET_` environment variables and command line arguments) could override the application-level configuration. This would prevent `GenericWebHostService` from seeing the latest configuration set by `UseUrls()` of `DOTNET_URLS`, `ASPNET_URLS` or `--urls` was set. Fixes #38185 ## Customer Impact This is a big gotcha to customers using `WebApplicationBuilder` (which is used in all the ASP.NET Core 6 templates) who expect the following to work: ```C# var builder = WebApplication.CreateBuilder(args); builder.WebHost.UseUrls("http://*:8080"); var app = builder.Build(); app.Run(); ``` A comment on the issue suggesting we patch this has gotten 5 thumbs ups not counting mine. ## Regression? - [ ] Yes - [x] No ## Risk - [ ] High - [ ] Medium - [x] Low This is a small well tested change which only affects the loading of default config sources and those added via a `HostFactoryResolver` to host configuration. [Here’s the existing test](https://github.com/dotnet/aspnetcore/blob/0f6f649f1da658bbe37b8898df0c80c5affa9d2d/src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs#L883) showing that the expected configuration providers are still dispose. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-runtime * Merge from github release/6.0 * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore dnceng/internal/dotnet-runtime - Set to private runtime * Merged PR 21869: Correct `--architecture` in `fpm` commands # {PR title} Correct `--architecture` in `fpm` commands ## Description Update `fpm` commands to use a supported `--architecture` value. As-is, the x64 .rpm files we produce are incompatible w/ installation on an x64 machine. Problem found during servicing version flow. ## Customer Impact Unable to build dotnet-installer-ci-official w/ current .rpm files from dotnet-aspnetcore repo. ## Regression? - [x] Yes - [ ] No This is a build regression since 6.0.3. It will also impact our 'main' branch. ## Risk - [ ] High - [ ] Medium - [x] Low Have verified the chosen values for the command line using available online documentation. Since we know the current .rpm files are busted, things can only get better 😃 ## Verification - [x] Manual (required) - [ ] Automated I am locally building this branch and will use `rpmlint` in a `docker` container to verify the goodness of the produced package. ## Packaging changes reviewed? - [ ] Yes - [ ] No - [ ] N/A Not sure how to answer this because the change is to an internal setting of the RPM installer. If others agree it's the right change, it's been reviewed 😃 ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props * Merged PR 21931: Revert "[release/6.0] Build ProjectTemplates in Source-Build (#40650)" (#40805) # {PR title} Summary of the changes (Less than 80 chars) ## Description {Detail} Fixes #{bug number} (in this specific format) ## Customer Impact {Justification} ## Regression? - [ ] Yes - [ ] No [If yes, specify the version the behavior has regressed from] ## Risk - [ ] High - [ ] Medium - [ ] Low [Justify the selection above] ## Verification - [ ] Manual (required) - [ ] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [ ] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props Revert "[release/6.0] Build ProjectTemplates in Source-Build (#40650)" (#40805) This reverts commit 7c2000d. Co-authored-by: dotnet-bot <[email protected]> Co-authored-by: DotNet Bot <[email protected]> Co-authored-by: Stephen Halter <[email protected]> Co-authored-by: mmitche <[email protected]> Co-authored-by: Doug Bunting (AAPT) <[email protected]>
Previously mentioned: #36245
Describe the bug
Builder.WebHost.UseUrls()
fails to use the port/url providedTo Reproduce
Further technical details
dotnet --info
:dotnet --info Output
The text was updated successfully, but these errors were encountered: