Fix: Project Names with Spaces Break the Build

[kiapanahi]

Fixes: #945.

I however couldn't find a solution for projects with (.) in their names.
I've figured out that the generated IServiceMetadata is correct but the actual name-of-project.AppHost template is outputting faulty template.

[DamianEdwards]

The issue when using a . in the project name seems like a regression from #510 but I'm not sure what's causing it. We might need help from the template engine folks because the name form we're using now should be indicating that we want the class form.

That said, you could try changing "sourceName": "AspireStarterApplication-1" to "sourceName": "AspireStarterApplication.1" and then change the reference to it in Program.cs to Projects.AspireStarterApplication__1_ApiService

If this works, it would be great if you could update it in the empty template too, and ensure the directory names, project files, etc. are updated to match.

[kiapanahi]

@DamianEdwards

Thank you for the pointers.
I'd love for you to take a look at the updated templates.

[DamianEdwards]

@kiapanahi have you tested the templates locally? After calling build.cmd -pack in the repo root, you should have a package like ./artifacts/packages/Release/Shipping/Aspire.ProjectTemplates.8.0.0-dev.nupkg that has the templates in it. You can install that locally by first deleting your template cache (~/.templateengine/packages directory and ~/.templateengine/packages.json) and then calling dotnet new -i <path-to-package.nupkg>. Then you can create some projects using your updated templates and verify the relevant scenarios (name with . in it, name with spaces in it, etc.).

[DamianEdwards]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[kiapanahi]

@DamianEdwards I did. The thing that I didn't test (to be honest didn't know how to test without much hassle) was the fix for replacing the single whitespace character with underlines which this PR fixes as well.

I think I know how to test it though. If I'm not wrong, I need to somehow reference my own build of Aspire.Hosting package instead of the !!REPLACE_WITH_LATEST_VERSION!! one which still contains the whitespace bug.

but the . part is fully tested locally.

[DamianEdwards]

I think I know how to test it though. I I'm not wrong, I need to somehow reference my own build of Aspire.Hosting package instead of the !!REPLACE_WITH_LATEST_VERSION!! one which still contains the whitespace bug.

You'll need to create a local NuGet feed that points at the artifacts directory of the repo (./artifacts/packages/Release/Shipping/). Then you can reference the -dev suffixed version which is what you built.

[kiapanahi]

Alright, I managed to test with the locally built -dev NuGet packages and I can confirm that the issue with the replacing of whitespace with underline is fixed.

[DamianEdwards]

Thanks for this!

[kiapanahi]

Thank you for all of your pointers and helps